10000 Removing constructor tests · lenchester/enqueue-dev@4c232c2 · GitHub
[go: up one dir, main page]
Skip to content

Commit 4c232c2

Browse files
JimToolsJimTools
committed
Removing constructor tests
Removing all tests that creates a new instance but doesn't call any methods nor preform any assertions.
1 parent a2177a5 commit 4c232c2

File tree

120 files changed

+0
-1046
lines changed
  • RdKafkaConsumerTest.php
  • RdKafkaProducerTest.php
  • redis/Tests
  • snsqs/Tests
  • sns/Tests
  • sqs/Tests
  • stomp/Tests
  • wamp/Tests/Spec

    • Some content is hidden

    Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

    120 files changed

    +0
    -1046
    lines changed

    ‎pkg/amqp-bunny/Tests/AmqpConsumerTest.php

    Lines changed: 0 additions & 8 deletions
    Original file line numberDiff line numberDiff line change
    @@ -27,14 +27,6 @@ public function testShouldImplementConsumerInterface()
    2727
    $this->assertClassImplements(Consumer::class, AmqpConsumer::class);
    2828
    }
    2929

    30-
    /**
    31-
    * @doesNotPerformAssertions
    32-
    */
    33-
    public function testCouldBeConstructedWithContextAndQueueAsArguments()
    34-
    {
    35-
    new AmqpConsumer($this->createContextMock(), new AmqpQueue('aName'));
    36-
    }
    37-
    3830
    public function testShouldReturnQueue()
    3931
    {
    4032
    $queue = new AmqpQueue('aName');

    ‎pkg/amqp-bunny/Tests/AmqpProducerTest.php

    Lines changed: 0 additions & 9 deletions
    Original file line numberDiff line numberDiff line change
    @@ -24,15 +24,6 @@ class AmqpProducerTest extends TestCase
    2424
    {
    2525
    use ClassExtensionTrait;
    2626

    27-
    /**
    28-
    * @doesNotPerformAssertions
    29-
    */
    30-
    31-
    public function testCouldBeConstructedWithRequiredArguments()
    32-
    {
    33-
    new AmqpProducer($this->createBunnyChannelMock(), $this->createContextMock());
    34-
    }
    35-
    3627
    public function testShouldImplementQueueInteropProducerInterface()
    3728
    {
    3829
    $this->assertClassImplements(Producer::class, AmqpProducer::class);

    ‎pkg/amqp-bunny/Tests/AmqpSubscriptionConsumerTest.php

    Lines changed: 0 additions & 8 deletions
    Original file line numberDiff line numberDiff line change
    @@ -17,14 +17,6 @@ public function testShouldImplementQueueInteropSubscriptionConsumerInterface()
    1717
    $this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
    1818
    }
    1919

    20-
    /**
    21-
    * @doesNotPerformAssertions
    22-
    */
    23-
    public function testCouldBeConstructedWithAmqpContextAsFirstArgument()
    24-
    {
    25-
    new AmqpSubscriptionConsumer($this->createAmqpContextMock());
    26-
    }
    27-
    2820
    /**
    2921
    * @return AmqpContext|MockObject
    3022
    */

    ‎pkg/amqp-ext/Tests/AmqpConsumerTest.php

    Lines changed: 0 additions & 8 deletions
    Original file line numberDiff line numberDiff line change
    @@ -19,14 +19,6 @@ public function testShouldImplementConsumerInterface()
    1919
    $this->assertClassImplements(Consumer::class, AmqpConsumer::class);
    2020
    }
    2121

    22-
    /**
    23-
    * @doesNotPerformAssertions
    24-
    */
    25-
    public function testCouldBeConstructedWithContextAndQueueAsArguments()
    26-
    {
    27-
    new AmqpConsumer($this->createContext(), new AmqpQueue('aName'));
    28-
    }
    29-
    3022
    /**
    3123
    * @return MockObject|AmqpContext
    3224
    */

    ‎pkg/amqp-ext/Tests/AmqpContextTest.php

    Lines changed: 0 additions & 18 deletions
    Original file line numberDiff line numberDiff line change
    @@ -28,24 +28,6 @@ public function testShouldImplementQueueInteropContextInterface()
    2828
    $this->assertClassImplements(Context::class, AmqpContext::class);
    2929
    }
    3030

    31-
    /**
    32-
    * @doesNotPerformAssertions
    33-
    */
    34-
    public function testCouldBeConstructedWithExtChannelAsFirstArgument()
    35-
    {
    36-
    new AmqpContext($this->createExtChannelMock());
    37-
    }
    38-
    39-
    /**
    40-
    * @doesNotPerformAssertions
    41-
    */
    42-
    public function testCouldBeConstructedWithExtChannelCallbackFactoryAsFirstArgument()
    43-
    {
    44-
    new AmqpContext(function () {
    45-
    return $this->createExtChannelMock();
    46-
    });
    47-
    }
    48-
    4931
    public function testThrowIfNeitherCallbackNorExtChannelAsFirstArgument()
    5032
    {
    5133
    $this->expectException(\InvalidArgumentException::class);

    ‎pkg/amqp-ext/Tests/AmqpSubscriptionConsumerTest.php

    Lines changed: 0 additions & 8 deletions
    Original file line numberDiff line numberDiff line change
    @@ -17,14 +17,6 @@ public function testShouldImplementQueueInteropSubscriptionConsumerInterface()
    1717
    $this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
    1818
    }
    1919

    20-
    /**
    21-
    * @doesNotPerformAssertions
    22-
    */
    23-
    public function testCouldBeConstructedWithAmqpContextAsFirstArgument()
    24-
    {
    25-
    new AmqpSubscriptionConsumer($this->createAmqpContextMock());
    26-
    }
    27-
    2820
    /**
    2921
    * @return AmqpContext|MockObject
    3022
    */

    ‎pkg/async-event-dispatcher/Tests/AsyncProcessorTest.php

    Lines changed: 0 additions & 8 deletions
    Original file line numberDiff line numberDiff line change
    @@ -24,14 +24,6 @@ public function testShouldImplementProcessorInterface()
    2424
    $this->assertClassImplements(Processor::class, AsyncProcessor::class);
    2525
    }
    2626

    27-
    /**
    28-
    * @doesNotPerformAssertions
    29-
    */
    30-
    public function testCouldBeConstructedWithRegistryAndProxyEventDispatcher()
    31-
    {
    32-
    new AsyncProcessor($this->createRegistryMock(), $this->createProxyEventDispatcherMock());
    33-
    }
    34-
    3527
    public function testRejectIfMessageMissingEventNameProperty()
    3628
    {
    3729
    $processor = new AsyncProcessor($this->createRegistryMock(), $this->createProxyEventDispatcherMock());

    ‎pkg/async-event-dispatcher/Tests/PhpSerializerEventTransformerTest.php

    Lines changed: 0 additions & 8 deletions
    Original file line numberDiff line numberDiff line change
    @@ -21,14 +21,6 @@ public function testShouldImplementEventTransformerInterface()
    2121
    $this->assertClassImplements(EventTransformer::class, PhpSerializerEventTransformer::class);
    2222
    }
    2323

    24-
    /**
    25-
    * @doesNotPerformAssertions
    26-
    */
    27-
    public function testCouldBeConstructedWithoutAnyArguments()
    28-
    {
    29-
    new PhpSerializerEventTransformer($this->createContextStub());
    30-
    }
    31-
    3224
    public function testShouldReturnMessageWithPhpSerializedEventAsBodyOnToMessage()
    3325
    {
    3426
    $transformer = new PhpSerializerEventTransformer($this->createContextStub());

    ‎pkg/async-event-dispatcher/Tests/SimpleRegistryTest.php

    Lines changed: 0 additions & 8 deletions
    Original file line numberDiff line numberDiff line change
    @@ -18,14 +18,6 @@ public function testShouldImplementRegistryInterface()
    1818
    $this->assertClassImplements(Registry::class, SimpleRegistry::class);
    1919
    }
    2020

    21-
    /**
    22-
    * @doesNotPerformAssertions
    23-
    */
    24-
    public function testCouldBeConstructedWithEventsMapAndTransformersMapAsArguments()
    25-
    {
    26-
    new SimpleRegistry([], []);
    27-
    }
    28-
    2921
    public function testShouldAllowGetTransportNameByEventName()
    3022
    {
    3123
    $registry = new SimpleRegistry([

    ‎pkg/dbal/Tests/DbalConsumerTest.php

    Lines changed: 0 additions & 8 deletions
    Original file line numberDiff line numberDiff line change
    @@ -28,14 +28,6 @@ public function testShouldImplementConsumerInterface()
    2828
    $this->assertClassImplements(Consumer::class, DbalConsumer::class);
    2929
    }
    3030

    31-
    /**
    32-
    * @doesNotPerformAssertions
    33-
    */
    34-
    public function testCouldBeConstructedWithRequiredArguments()
    35-
    {
    36-
    new DbalConsumer($this->createContextMock(), new DbalDestination('queue'));
    37-
    }
    38-
    3931
    public function testShouldReturnInstanceOfDestination()
    4032
    {
    4133
    $destination = new DbalDestination('queue');

    0 commit comments

    Comments
     (0)
    0