Update src/Symfony/Component/DependencyInjection/Container.php

lchenay · lchenay · commit 82ee78c05bd2 · 2012-08-22T15:57:23.000+03:00
This throw an exception and should not with isset:

'something' exist as service

$this-&gt;container-&gt;set('something', null);

if (null !== $this-&gt;container-&gt;get('something')) {
    throw new \Exception('Should be null');
}
diff --git a/src/Symfony/Component/DependencyInjection/Container.php b/src/Symfony/Component/DependencyInjection/Container.php
@@ -238,7 +238,7 @@ public function get($id, $invalidBehavior = self::EXCEPTION_ON_INVALID_REFERENCE
     {
         $id = strtolower($id);
 
-        if (isset($this->services[$id])) {
+        if (array_key_exists($id, $this->services)) {
             return $this->services[$id];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ public function get($id, $invalidBehavior = self::EXCEPTION_ON_INVALID_REFERENCE`
`238`	`238`	`{`
`239`	`239`	`$id = strtolower($id);`
`240`	`240`
`241`		`- if (isset($this->services[$id])) {`
	`241`	`+ if (array_key_exists($id, $this->services)) {`
`242`	`242`	`return $this->services[$id];`
`243`	`243`	`}`
`244`	`244`