[Form] PropertyPath camelizes property names when setting values

Bernhard Schussek · fabpot · commit b902cb31d715 · 2010-10-11T12:52:22.000+02:00
diff --git a/src/Symfony/Component/Form/PropertyPath.php b/src/Symfony/Component/Form/PropertyPath.php
@@ -353,7 +353,7 @@ protected function updateProperty(&$objectOrArray, $currentIndex, $value)
             $objectOrArray[$property] = $value;
         } else if (is_object($objectOrArray)) {
             $reflClass = new \ReflectionClass($objectOrArray);
-            $setter = 'set'.ucfirst($property); // TODO camelize correctly
+            $setter = 'set'.$this->camelize($property);
 
             if ($reflClass->hasMethod($setter)) {
                 if (!$reflClass->getMethod($setter)->isPublic()) {
diff --git a/tests/Symfony/Tests/Component/Form/PropertyPathTest.php b/tests/Symfony/Tests/Component/Form/PropertyPathTest.php
@@ -97,6 +97,16 @@ public function testGetValueReadsGetters()
         $this->assertEquals('Schussek', $path->getValue($object));
     }
 
+    public function testGetValueCamelizesGetterNames()
+    {
+        $path = new PropertyPath('last_name');
+
+        $object = new Author();
+        $object->setLastName('Schussek');
+
+        $this->assertEquals('Schussek', $path->getValue($object));
+    }
+
     public function testGetValueThrowsExceptionIfGetterIsNotPublic()
     {
         $path = new PropertyPath('privateGetter');
@@ -205,6 +215,16 @@ public function testSetValueUpdatesSetters()
         $this->assertEquals('Schussek', $object->getLastName());
     }
 
+    public function testSetValueCamelizesSetterNames()
+    {
+        $object = new Author();
+
+        $path = new PropertyPath('last_name');
+        $path->setValue($object, 'Schussek');
+
+        $this->assertEquals('Schussek', $object->getLastName());
+    }
+
     public function testSetValueThrowsExceptionIfGetterIsNotPublic()
     {
         $path = new PropertyPath('privateSetter');
