InputDefinition: corrected grammar mistakes and added a @throws declaration

nanocom · nanocom · commit c0997634efa4 · 2012-06-18T23:37:16.000+02:00
diff --git a/src/Symfony/Component/Console/Input/InputDefinition.php b/src/Symfony/Component/Console/Input/InputDefinition.php
@@ -113,7 +113,7 @@ public function addArguments($arguments = array())
     public function addArgument(InputArgument $argument)
     {
         if (isset($this->arguments[$argument->getName()])) {
-            throw new \LogicException(sprintf('An argument with name "%s" already exist.', $argument->getName()));
+            throw new \LogicException(sprintf('An argument with name "%s" already exists.', $argument->getName()));
         }
 
         if ($this->hasAnArrayArgument) {
@@ -262,9 +262,9 @@ public function addOptions($options = array())
     public function addOption(InputOption $option)
     {
         if (isset($this->options[$option->getName()]) && !$option->equals($this->options[$option->getName()])) {
-            throw new \LogicException(sprintf('An option named "%s" already exist.', $option->getName()));
+            throw new \LogicException(sprintf('An option named "%s" already exists.', $option->getName()));
         } elseif (isset($this->shortcuts[$option->getShortcut()]) && !$option->equals($this->options[$this->shortcuts[$option->getShortcut()]])) {
-            throw new \LogicException(sprintf('An option with shortcut "%s" already exist.', $option->getShortcut()));
+            throw new \LogicException(sprintf('An option with shortcut "%s" already exists.', $option->getShortcut()));
         }
 
         $this->options[$option->getName()] = $option;
@@ -280,6 +280,8 @@ public function addOption(InputOption $option)
      *
      * @return InputOption A InputOption object
      *
+     * @throws \InvalidArgumentException When option given doesn't exist
+     *
      * @api
      */
     public function getOption($name)

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public function addArguments($arguments = array())`
`113`	`113`	`public function addArgument(InputArgument $argument)`
`114`	`114`	`{`
`115`	`115`	`if (isset($this->arguments[$argument->getName()])) {`
`116`		`- throw new \LogicException(sprintf('An argument with name "%s" already exist.', $argument->getName()));`
	`116`	`+ throw new \LogicException(sprintf('An argument with name "%s" already exists.', $argument->getName()));`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`if ($this->hasAnArrayArgument) {`
`@@ -262,9 +262,9 @@ public function addOptions($options = array())`
`262`	`262`	`public function addOption(InputOption $option)`
`263`	`263`	`{`
`264`	`264`	`if (isset($this->options[$option->getName()]) && !$option->equals($this->options[$option->getName()])) {`
`265`		`- throw new \LogicException(sprintf('An option named "%s" already exist.', $option->getName()));`
	`265`	`+ throw new \LogicException(sprintf('An option named "%s" already exists.', $option->getName()));`
`266`	`266`	`} elseif (isset($this->shortcuts[$option->getShortcut()]) && !$option->equals($this->options[$this->shortcuts[$option->getShortcut()]])) {`
`267`		`- throw new \LogicException(sprintf('An option with shortcut "%s" already exist.', $option->getShortcut()));`
	`267`	`+ throw new \LogicException(sprintf('An option with shortcut "%s" already exists.', $option->getShortcut()));`
`268`	`268`	`}`
`269`	`269`
`270`	`270`	`$this->options[$option->getName()] = $option;`
`@@ -280,6 +280,8 @@ public function addOption(InputOption $option)`
`280`	`280`	`*`
`281`	`281`	`* @return InputOption A InputOption object`
`282`	`282`	`*`
	`283`	`+ * @throws \InvalidArgumentException When option given doesn't exist`
	`284`	`+ *`
`283`	`285`	`* @api`
`284`	`286`	`*/`
`285`	`287`	`public function getOption($name)`