Changing return type of 'requestFrom' from uint8_t to size_t allows the function to return the correct amount of bytes read (since internally it's already a size_t which is downcast to a uint8_t upon returning it. (arduino#132)

aentinger · web-flow · commit 4f194387a356 · 2020-12-10T10:18:20.000+01:00
diff --git a/api/HardwareI2C.h b/api/HardwareI2C.h
@@ -36,8 +36,8 @@ class HardwareI2C : public Stream
     virtual uint8_t endTransmission(bool stopBit) = 0;
     virtual uint8_t endTransmission(void) = 0;
 
-    virtual uint8_t requestFrom(uint8_t address, size_t len, bool stopBit) = 0;
-    virtual uint8_t requestFrom(uint8_t address, size_t len) = 0;
+    virtual size_t requestFrom(uint8_t address, size_t len, bool stopBit) = 0;
+    virtual size_t requestFrom(uint8_t address, size_t len) = 0;
 
     virtual void onReceive(void(*)(int)) = 0;
     virtual void onRequest(void(*)(void)) = 0;
