8000 readonly make cells not selectable · Issue #284 · larray-project/larray-editor · GitHub
[go: up one dir, main page]
Skip to content

readonly make cells not selectable #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gdementen opened this issue Nov 6, 2024 · 0 comments
Open

readonly make cells not selectable #284

gdementen opened this issue Nov 6, 2024 · 0 comments
Labels
bug difficulty: low
Milestone
0.35

Comments

@gdementen
Copy link
Collaborator
gdementen commented Nov 6, 2024 •
edited
Loading

(discovered in promes_output)

Our DataArrayModel.flags method is slightly buggy:

  • when readonly, we need the flag ItemIsSelectable. When the cell is editable, this is (apparently) implied, but specifying it explicitly wouldn't hurt
  • It would be more correct to return NoItemFlags for invalid indices

References:
@gdementen gdementen added this to the 0.35 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug difficulty: low
Projects
None yet
Milestone
0.35
Development

No branches or pull requests
1 participant
@gdementen
0