editing cells with duplicate labels does not work #161
Comments
gdementen
added a commit
to gdementen/larray-editor
that referenced
this issue
Sep 27, 2021
the main goal was to make writing adapters easier and to avoid having to load all data in memory
remaining issues:
* to make it work nicely with partially visible cells I used a shortcut and tweaked some limits by 1 but it gives odd behavior when all cells are visible (visible area >= array)
fixing this properly is possible but not trivial
* implemented adapters for
- pandas DataFrame
- pandas Series
- list
- pytables.Table
- binary files
- text files
- pstats.Stats (profiling stats)
- Path objects
- directory Path
- .sas7bdat
- .csv
- .py
* fixed larray-project#161: use indices for filters (to avoid problems with duplicate labels)
* fixed single column plot in viewer when ticks are not strings
* added support for plot with more than 1 dimension in columns (by making plot axes labels customizable by the adapter)
gdementen
added a commit
that referenced
this issue
Oct 12, 2023
* fixed #161: use indices for filters (to avoid problems with duplicate labels) * fixed single column plot in viewer when ticks are not strings * added support for plot with more than 1 dimension in columns (by making plot axes labels customizable by the adapter) * allow registering an adapter via an explicit function call instead of via a decorator * adapters can be registered using a string (so that we do not load the module just to register the adapter) looked-up adapters are cached for faster retrieval for subsequent instances of that type * adapters are used to display instances of their subclasses. When there is both an adapter for a parent class and a subclass, we use the adapter for the subclass by sorting registered types by the length of their mro. Note that string types always come last (so we cannot have two string types inheriting from each other) * added support for per-column color value * WIP: adapters can return simple sequences instead of ndarrays (buggy for list of sequences) * split get_adapter in two steps: get_adapter_creator which gets a callable and calling that callable to actually get an adapter * made writing adapters easier and to avoid having to load all data in memory remaining issues: * to make it work nicely with partially visible cells I used a shortcut and tweaked some limits by 1 but it gives odd behavior when all cells are visible (visible area >= array) fixing this properly is possible but not trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
because the key is label-based. It should be indices-based. Should be done after #33 is merged because of the large refactor it introduces.
The text was updated successfully, but these errors were encountered: