CLN: fixed a few style issues reported by ruff 0.5

gdementen · gdementen · commit bb9933410d17 · 2024-07-16T15:28:05.000+02:00
and silence false positives
diff --git a/larray/core/axis.py b/larray/core/axis.py
@@ -111,7 +111,7 @@ def __init__(self, labels, name=None):
 
         # make sure we do not have np.str_ as it causes problems down the
         # line with xlwings. Cannot use isinstance to check that though.
-        name_is_python_str = type(name) is str or type(name) is bytes
+        name_is_python_str = type(name) is str or type(name) is bytes  # noqa: E721
         if isinstance(name, str) and not name_is_python_str:
             name = str(name)
         if name is not None and not isinstance(name, (int, str)):
diff --git a/larray/tests/test_array.py b/larray/tests/test_array.py
@@ -217,7 +217,7 @@ def test_ndtest():
 
 
 def test_getattr(array):
-    assert type(array.b) == Axis
+    assert isinstance(array.b, Axis)
     assert array.b is b
     with must_raise(AttributeError, msg="'Array' object has no attribute 'bm'"):
         _ = array.bm
diff --git a/larray/tests/test_excel.py b/larray/tests/test_excel.py
@@ -192,8 +192,9 @@ def test_get_and_set_item(self):
             obj_arr_dump = obj_arr.dump()
             # [['a\\b', 'b0', 'b1', 'b2'], ['a0', 0, nan, 2], ['a1', 3, 4, 5]]
 
-            # float and *not* np.float64, otherwise it gets converted to 65535 when written to Excel
-            assert type(obj_arr_dump[1][2]) is float
+            # float and *not* np.float64 (which inherits from float), otherwise it gets
+            # converted to 65535 when written to Excel
+            assert type(obj_arr_dump[1][2]) is float  # noqa: E721
 
             sheet['A12'] = obj_arr_dump
 
diff --git a/larray/tests/test_session.py b/larray/tests/test_session.py
@@ -155,13 +155,13 @@ def test_add(session):
     with must_warn((UserWarning, FutureWarning), match='.*', num_expected=None) as caught_warnings:
         session.add(i, i01, j='j')
 
-    future_warnings = [w for w in caught_warnings if w.category == FutureWarning]
+    future_warnings = [w for w in caught_warnings if w.category is FutureWarning]
     assert len(future_warnings) == 1
     # .message is the w object itself, .message.args[0] is the actual message
     assert future_warnings[0].message.args[0] == "Session.add() is deprecated. Please use Session.update() instead."
 
     if isinstance(session, CheckedSession):
-        user_warnings = [w for w in caught_warnings if w.category == UserWarning]
+        user_warnings = [w for w in caught_warnings if w.category is UserWarning]
         assert len(user_warnings) == 3
         assert all(re.match(r"'\w+' is not declared in 'CheckedSessionExample'", w.message.args[0])
                    for w in user_warnings)
