Free PQresult on error in pg_receivexlog.

hlinnaka · hlinnaka · commit e158bbb6e95a · 2014-05-12T11:01:20.000+03:00
The leak is fairly small and rare, but a leak nevertheless.

Per Coverity report. Backpatch to 9.2, where pg_receivexlog was added.
pg_basebackup shares the code, but it always exits on error, so there is
no real leak.
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
@@ -612,6 +612,7 @@ ReceiveXlogStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,
 		fprintf(stderr,
 				_("%s: unexpected termination of replication stream: %s"),
 				progname, PQresultErrorMessage(res));
+		PQclear(res);
 		goto error;
 	}
 	PQclear(res);

Original file line number	Diff line number	Diff line change
`@@ -612,6 +612,7 @@ ReceiveXlogStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,`
`612`	`612`	`fprintf(stderr,`
`613`	`613`	`_("%s: unexpected termination of replication stream: %s"),`
`614`	`614`	`progname, PQresultErrorMessage(res));`
	`615`	`+ PQclear(res);`
`615`	`616`	`goto error;`
`616`	`617`	`}`
`617`	`618`	`PQclear(res);`