Use assertFalse and assertTrue

carusogabriel · carusogabriel · commit 25667fc2edf6 · 2017-11-30T11:59:54.000-02:00
diff --git a/tests/FullApplicationTest.php b/tests/FullApplicationTest.php
@@ -356,7 +356,7 @@ public function testMiddlewareReceiveResponsesEvenWhenStringReturned()
         $response = $app->handle(Request::create('/', 'GET'));
         $this->assertEquals(200, $response->getStatusCode());
         $this->assertEquals('Hello World', $response->getContent());
-        $this->assertEquals(true, $_SERVER['__middleware.response']);
+        $this->assertTrue($_SERVER['__middleware.response']);
     }
 
     public function testBasicControllerDispatching()
@@ -460,7 +460,7 @@ public function testRunningUnitTestsDetection()
     {
         $app = new Application;
 
-        $this->assertEquals(false, $app->runningUnitTests());
+        $this->assertFalse($app->runningUnitTests());
     }
 
     public function testValidationHelpers()
diff --git a/tests/Http/ResponseFactoryTest.php b/tests/Http/ResponseFactoryTest.php
@@ -38,7 +38,7 @@ public function testDownloadDefaultResponse()
         $response = $responseFactory->download($temp);
 
         $this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
-        $this->assertEquals(false, $response->getContent());
+        $this->assertFalse($response->getContent());
         $this->assertEquals(Response::HTTP_OK, $response->getStatusCode());
 
         unlink($temp);

Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,7 @@ public function testMiddlewareReceiveResponsesEvenWhenStringReturned()`
`356`	`356`	`$response = $app->handle(Request::create('/', 'GET'));`
`357`	`357`	`$this->assertEquals(200, $response->getStatusCode());`
`358`	`358`	`$this->assertEquals('Hello World', $response->getContent());`
`359`		`- $this->assertEquals(true, $_SERVER['__middleware.response']);`
	`359`	`+ $this->assertTrue($_SERVER['__middleware.response']);`
`360`	`360`	`}`
`361`	`361`
`362`	`362`	`public function testBasicControllerDispatching()`
`@@ -460,7 +460,7 @@ public function testRunningUnitTestsDetection()`
`460`	`460`	`{`
`461`	`461`	`$app = new Application;`
`462`	`462`
`463`		`- $this->assertEquals(false, $app->runningUnitTests());`
	`463`	`+ $this->assertFalse($app->runningUnitTests());`
`464`	`464`	`}`
`465`	`465`
`466`	`466`	`public function testValidationHelpers()`