8000 [9.x] Handle Symfony defaultName deprecation by driesvints · Pull Request #41555 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

[9.x] Handle Symfony defaultName deprecation #41555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2022
Merged

[9.x] Handle Symfony defaultName deprecation #41555

merged 4 commits into from
Mar 18, 2022

Conversation

driesvints
Copy link
Member

This PR adds handling for Symfony's deprecated $defaultName property on console commands in the upcoming Symfony 6.1 release. To mitigate deprecation notices we'll need to implement the new AsCommand attribute that ships with Symfony v6.

See the related Symfony PR: symfony/symfony#45361
And issue: symfony/symfony#43600

Merging this into master will fix our failing tests there. After this is merged on master, I'll take the additional step to remove all $defaultName properties.

We'll also need to do this for all first party libraries that make use of the $defaultName property. Additionally, all apps and packages that make use of the $defaultName property will need to migrate to this new syntax.

@driesvints driesvints marked this pull request as ready for review March 18, 2022 10:01
Jubeki
Jubeki reviewed Mar 18, 2022
View reviewed changes
@taylorotwell taylorotwell merged commit d2fb4a7 into 9.x Mar 18, 2022
@taylorotwell taylorotwell deleted the handle-console-deprecations branch March 18, 2022 13:48
@adideas adideas mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jubeki Jubeki Jubeki left review comments

@adideas adideas adideas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@driesvints @Jubeki @adideas @taylorotwell @StyleCIBot
0