[Request] Extend Eloquent plurality to hasMany() #89

jackmcdade · 2013-01-18T04:44:57Z

Obviously not a game-breaker, but Eloquent's smart plurality does not extend to hasMany(), which just feels awkward gramatically. Example:

<?php

class Group extends Eloquent {

    public function subscribers()
    {
        return $this->hasMany('Subscriber');
    }

}

The text was updated successfully, but these errors were encountered:

taylorotwell · 2013-01-18T06:19:44Z

What do you mean? You mean you want to do this?

return $this->hasMany('Subscribers');

jackmcdade · 2013-01-18T06:22:35Z

Yep, that's it. Probably just my Rails side leaking over, but it would "feel" more right to me.

Anahkiasen · 2013-01-18T08:56:54Z

I kind of feel silly agreeing with this but this has always bugged me as well. Not top priority of course.

franzliedke · 2013-01-18T09:53:10Z

-1. I think that's too much magic, too easy to break, and useless with namespaces for model classes.

jasonlewis · 2013-01-18T10:19:00Z

👎

Sopamo · 2013-01-18T12:08:03Z

👎

Anahkiasen · 2013-01-18T12:19:14Z

Ah didn't think about namespaced models yeah.

JoostK · 2013-01-18T13:27:20Z

I never li 8000 ke using a class name as a string. I would much rather use:

return $this->hasMany(Subscriber::class());

Now it is clear that a Model is being referred to, and you can also forget to specify the namespace, as now PHP will do that for you. It's a pity PHP doesn't implement the class method by default but it's very easy to add it:

public static function class()
{
    return get_called_class();
}

This can also be done with routing:

Route::get('home/test', HomeController::at('test'));

Automatic namespace resolution and early errors (class does not exists maybe) are the biggest benefits of this approach.

franzliedke · 2013-01-18T13:32:16Z

@JoostK I am confused. You still have to import the class. And not unlike with 'Subscriber', you still have to write the class name when doing Subscriber::class().

JoostK · 2013-01-18T13:36:45Z

For me it's just clearer. Importing is only necessary once per file, then you're good to go for multiple statements.

Also, models are mostly all in the same namespace, so you don't even have to import the namespace/class and it will automatically be correct when e.g. the namespace changes. With just as string you don't have that benefits.

As it just generates a string you can still use a string directly, if you want though.

taylorotwell · 2013-01-18T13:39:15Z

Yeah, it's always just been the model name. Think it would be more confusing to switch at this point.

franzliedke · 2013-01-18T13:43:33Z

Thanks for the clarification, @JoostK. Makes sense now.

taylorotwell closed this as completed Jan 18, 2013

mantas-done mentioned this issue May 14, 2025

Http client doesnt handle GuzzleHttp\Exception\RequestException #55733

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Request] Extend Eloquent plurality to hasMany() #89

[Request] Extend Eloquent plurality to hasMany() #89

[Request] Extend Eloquent plurality to hasMany() #89

[Request] Extend Eloquent plurality to hasMany() #89

Comments