-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Updating symfony/http-foundation (v6.1.4 => v6.1.5) brokes file download #44399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for making us aware. We hope Symfony patches this soon. |
For information of other Laravel users ending up here instead of in the Symfony issue: Passing the headers as a list ( It appears 6.1.5 includes a bug in the automatic configuration of content-type. As the content-type header in the parameter was never understood, the co 8000 de shown in this issue is relying on the automatic configuration. |
Thanks @wouterj. I don't think we document using it like that and if we do we'd be happy to correct those if anyone can find them. |
Not true. We were (guilty and wrongly) using it in 3 different projects and it worked (since a lot of time, about 2 year the oldest commit). Anywhere, there is no documentation about HOW to send headers and I think laravel doc team should add a small example |
Yes, but also there is not documentation about the right way to do it. There is no documentation about HOW to send headers and I think laravel doc team should add a small example |
It has worked by the shear luck that the automatic content type algorithm produced the same content type as you were passing. Doing
I'm sure they welcome contributions :) |
I understand and I agree. |
I have not clear in mind why.. but in previous version of pair laravel + httpfoundation it worked in a different way. |
Apparently, this should be fixed with the next symfony release: Symfony Github Does anybody know when that will be relased? |
Description:
We upgraded from v9.27.0 => v9.28.0.
This syntax, note $headers, not works anymore
This only works now
This is due to the upgrade from a symfony package
Actual result is that downloading a pdf with a mimetype is not working anymore because we syy in the response an header "0" with value of 'Content-Type: application/pdf'
Steps To Reproduce:
Go back until symfony/http-foundatio will back to 6.1.4.
Use old syntax
Upgrade until symfony/http-foundatio will upgrade to 6.1.5.
String array will no work any amore.
Only associative array works.
This is the guilty commit: symfony/symfony@7023db1
I opened an issue on symfony also : symfony/symfony#47747
The text was updated successfully, but these errors were encountered: