8000 Do HasAttributes::originalIsEquivalent public · Issue #26383 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

Do HasAttributes::originalIsEquivalent public #26383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pablorsk opened this issue Nov 4, 2018 · 1 comment
Closed

Do HasAttributes::originalIsEquivalent public #26383

pablorsk opened this issue Nov 4, 2018 · 1 comment

Comments

@pablorsk
Copy link
Contributor
pablorsk commented Nov 4, 2018

This function is great for observers... For example on saving() event:

    public function saving(Product $product): void {
        if ($product->stock !== $product->getOriginal('stock')) {
            // do stuff
        }
    }

Is possible to change this? Or is there a reason to keep it that way?
@pablorsk pablorsk mentioned this issue Nov 4, 2018
Closed
@laurencei
Copy link
Contributor

I'm going to close the issue here, as you've done a PR. As per the PR from Taylor - send it to the master branch, so it can be included in Laravel 5.8

@pablorsk pablorsk mentioned this issue Nov 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pablorsk @laurencei
0