Running phpstan in the framework code #56203

victornoleto · 2025-07-03T02:41:41Z

victornoleto
Jul 3, 2025

I recently found out about phpstan/larastan and decided to apply it to my code. I was shocked when I ran it at max level and then followed the strategy of running the level 0, fixing the errors, leveling up and continuing in this loop.

I reached level 7, with the level 8 errors already mapped. Honestly, after level 6 it got really annoying because the errors start to be like "be as specific as possible". But ok, I get the idea and I'm honestly happy to have found such a simple tool to show me the way to develop better code.

Out of curiosity, I would like to know if the framework code (this repository here) would be suitable with phpstan at some level. I was confident that it would be max level, but it would "accept" something around 5~6. The surprise for me was to see that at level 0 it presents 958 errors. At level 6, this number increases to 9,364.

Of course, the framework is very complete and has many files (according to phpstan validation, 1,441 specifically), but this raised a curiosity in me: if phpstan is "not important to them", should it be to me? I have laravel and all its other tools/applications as a reference. I want to develop the way they do.

And please, don't get me wrong. I'm not here to badmouth the framework (or phpstan itself). It's really just a curiosity to understand how "quality/standardization metrics" work in the development and maintenance of the framework, because I would like to follow them.

To complement the discussion in this post, I would like to share the results I also did with laravel/pint and nunomaduro/phpinsights.

Pint found only one tweak in the entire code.

+++ b/src/Illuminate/Validation/InvokableValidationRule.php
@@ -68,7 +68,8 @@ protected function __construct(ValidationRule|InvokableRule $invokable)
     public static function make($invokable)
     {
         if ($invokable->implicit ?? false) {
-            return new class($invokable) extends InvokableValidationRule implements ImplicitRule {
+            return new class($invokable) extends InvokableValidationRule implements ImplicitRule
+            {
             };
         }

PHP Insights results:

                51.5%                   81.1%                   35.3%                   81.9% 
                 Code                 Complexity             Architecture               Style

Score scale: ◼ 1-49 ◼ 50-79 ◼ 80-100

[CODE] 51.5 pts within 135938 lines

Comments ...................................................... 70.7 %
Classes ....................................................... 22.6 %
Functions ...................................................... 1.5 %
Globally ....................................................... 5.1 %

[COMPLEXITY] 81.1 pts with average of 1.84 cyclomatic complexity

[ARCHITECTURE] 35.3 pts within 1424 files

Classes ....................................................... 76.1 %
Interfaces .................................................... 11.6 %
Globally ....................................................... 0.4 %
Traits ........................................................ 11.9 %

[MISC] 81.9 pts on coding style and 0 security issues encountered

macropay-solutions · 2025-07-03T08:45:40Z

macropay-solutions
Jul 3, 2025

The magic of laravel is not getting along with these code analyzers. We also encountered same type of results when running code analyzers on the framework.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Running phpstan in the framework code #56203

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 1 comment

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Running phpstan in the framework code #56203

Uh oh!

Uh oh!

victornoleto Jul 3, 2025

Replies: 1 comment

Uh oh!

macropay-solutions Jul 3, 2025

victornoleto
Jul 3, 2025

macropay-solutions
Jul 3, 2025