Free reserved memory before handling fatal errors (#42630)

spawnia · web-flow · commit 5094350a68fb · 2022-06-02T09:49:52.000-05:00
When the PHP process exceeds the configured memory limit,
a fatal error such as the following occurs:

```
Allowed memory size of 1073741824 bytes exhausted (tried to allocate 3358976 bytes)
```

Currently, the process abruptly exits in such cases without
and indication as to what has caused the error. This is
because the handler from `register_shutdown_function()`
attempts to instantiate a `FatalError` instance, thus trying
to use memory that is not available.

This clears the reserved memory before this instantiation,
thus ensuring that the process has enough memory to
properly handle the error. Reserved memory is also cleared
in `handleException` in the same way.
diff --git a/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php b/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php
@@ -159,9 +159,9 @@ protected function ensureNullLogDriverIsConfigured()
      */
     public function handleException(Throwable $e)
     {
-        try {
-            self::$reservedMemory = null;
+        self::$reservedMemory = null;
 
+        try {
             $this->getExceptionHandler()->report($e);
         } catch (Exception $e) {
             //
@@ -217,6 +217,8 @@ public function handleShutdown()
      */
     protected function fatalErrorFromPhpError(array $error, $traceOffset = null)
     {
+        self::$reservedMemory = null;
+
         return new FatalError($error['message'], 0, $error, $traceOffset);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -159,9 +159,9 @@ protected function ensureNullLogDriverIsConfigured()`
`159`	`159`	`*/`
`160`	`160`	`public function handleException(Throwable $e)`
`161`	`161`	`{`
`162`		`- try {`
`163`		`- self::$reservedMemory = null;`
	`162`	`+ self::$reservedMemory = null;`
`164`	`163`
	`164`	`+ try {`
`165`	`165`	`$this->getExceptionHandler()->report($e);`
`166`	`166`	`} catch (Exception $e) {`
`167`	`167`	`//`
`@@ -217,6 +217,8 @@ public function handleShutdown()`
`217`	`217`	`*/`
`218`	`218`	`protected function fatalErrorFromPhpError(array $error, $traceOffset = null)`
`219`	`219`	`{`
	`220`	`+ self::$reservedMemory = null;`
	`221`	`+`
`220`	`222`	`return new FatalError($error['message'], 0, $error, $traceOffset);`
`221`	`223`	`}`
`222`	`224`