Add workaround to use Memcached 3.0.0 for PHP7 with Many, Fix issues in #13002 with < 3.0.0

nikkiii · nikkiii · commit 38e247e3e339 · 2016-10-03T17:03:28.000-04:00
diff --git a/src/Illuminate/Cache/MemcachedStore.php b/src/Illuminate/Cache/MemcachedStore.php
@@ -5,6 +5,7 @@
 use Memcached;
 use Carbon\Carbon;
 use Illuminate\Contracts\Cache\Store;
+use ReflectionMethod;
 
 class MemcachedStore extends TaggableStore implements Store
 {
@@ -22,6 +23,13 @@ class MemcachedStore extends TaggableStore implements Store
      */
     protected $prefix;
 
+    /**
+     * A flag indicating whether the Memcached version is >= 3.0.0
+     *
+     * @var bool
+     */
+    protected $memcached_version_3_0;
+
     /**
      * Create a new Memcached store.
      *
@@ -33,6 +41,7 @@ public function __construct($memcached, $prefix = '')
     {
         $this->setPrefix($prefix);
         $this->memcached = $memcached;
+        $this->memcached_version_3_0 = (new ReflectionMethod('Memcached', 'getMulti'))->getNumberOfParameters() == 2;
     }
 
     /**
@@ -64,7 +73,12 @@ public function many(array $keys)
             return $this->prefix.$key;
         }, $keys);
 
-        $values = $this->memcached->getMulti($prefixedKeys, null, Memcached::GET_PRESERVE_ORDER);
+        if ($this->memcached_version_3_0) {
+            $values = $this->memcached->getMulti($prefixedKeys, Memcached::GET_PRESERVE_ORDER);
+        } else {
+            $null = null;
+            $values = $this->memcached->getMulti($prefixedKeys, $null, Memcached::GET_PRESERVE_ORDER);
+        }
 
         if ($this->memcached->getResultCode() != 0) {
             return array_fill_keys($keys, null);
