-
Notifications
You must be signed in to change notification settings - Fork 4.8k
[9.x] Add Symfony Mailer to Upgrade Guide #7454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Jubeki
wants to merge
18
commits into
laravel:master
from
Jubeki:add-symfony-mailer-to-upgrade-guide
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b599b96
Add Symfony Mailer to Upgrade Guide
Jubeki c93cece
Add example for updated Illuminate\Mail\Message
Jubeki 71ce90b
Add example for Stream Options for SMTP transport
Jubeki 45eab6a
Add methods which need to be renamed from Swift to Symfony
Jubeki f09511f
Add methods which need to be renamed from Swift to Symfony
Jubeki 7554b02
Fix initial paragraph
Jubeki 5eaa110
Add empty line
Jubeki 3ca6255
Wrap Classes in Code aposotrophes
Jubeki f8a96d1
Add empty line and fix code in sentence
Jubeki 6be7742
Add empty line
Jubeki 867da4a
Add empty line and end sentence correctly
Jubeki cc88fdc
Add empty line and fix typo
Jubeki b66564c
Add empty line
Jubeki f3c3aee
Add empty line
Jubeki 283e32f
Add empty line and fix typo
Jubeki db34d66
Add empty line
Jubeki 8ce23e5
Fix code example spacing
Jubeki cfdf664
Fix typo and Add empty line
Jubeki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
10000
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taylorotwell
A
TransportExceptionInterface
will be thrown if the email could not be send.https://symfony.com/doc/current/mailer.html#handling-sending-failures
The failed recipients are an artifact of
Swift_RfcComplianceException
, thus holds the invalid address (you can validate this yourself as well, before sending)symfony/symfony#33812
It would probably be better to word it something like this: