8000 Rename "duration" to "durationInSeconds" · lapolinarweb/rushstack@f4e3dd6 · GitHub
[go: up one dir, main page]
Skip to content

Commit f4e3dd6

Browse files
iclanton
committed
Rename "duration" to "durationInSeconds"
1 parent 257190d commit f4e3dd6

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

‎apps/rush-lib/src/cli/actions/BaseInstallAction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ export abstract class BaseInstallAction extends BaseRushAction {
197197
};
198198
this.parser.telemetry.log({
199199
name: 'install',
200-
duration: stopwatch.duration,
200+
durationInSeconds: stopwatch.duration,
201201
result: success ? 'Succeeded' : 'Failed',
202202
extraData
203203
});

‎apps/rush-lib/src/cli/scriptActions/PhasedScriptAction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ export class PhasedScriptAction extends BaseScriptAction<IPhasedCommandConfig> {
477477
if (this.parser.telemetry) {
478478
this.parser.telemetry.log({
479479
name: this.actionName,
480-
duration: stopwatch.duration,
480+
durationInSeconds: stopwatch.duration,
481481
result: success ? 'Succeeded' : 'Failed',
482482
extraData
483483
});

‎apps/rush-lib/src/logic/Telemetry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export interface ITelemetryData {
2020
/**
2121
* Duration in seconds
2222
*/
23-
readonly duration: number;
23+
readonly durationInSeconds: number;
2424
/**
2525
* The result of the command
2626
*/

‎apps/rush-lib/src/logic/test/Telemetry.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describe(Telemetry.name, () => {
3535
const telemetry: Telemetry = new Telemetry(rushConfig, rushSession);
3636
const logData1: ITelemetryData = {
3737
name: 'testData1',
38-
duration: 100,
38+
durationInSeconds: 100,
3939
result: 'Succeeded',
4040
timestamp: new Date().getTime(),
4141
platform: process.platform,
@@ -44,7 +44,7 @@ describe(Telemetry.name, () => {
4444

4545
const logData2: ITelemetryData = {
4646
name: 'testData2',
47-
duration: 100,
47+
durationInSeconds: 100,
4848
result: 'Failed',
4949
timestamp: new Date().getTime(),
5050
platform: process.platform,
@@ -66,7 +66,7 @@ describe(Telemetry.name, () => {
6666
const telemetry: Telemetry = new Telemetry(rushConfig, rushSession);
6767
const logData: ITelemetryData = {
6868
name: 'testData',
69-
duration: 100,
69+
durationInSeconds: 100,
7070
result: 'Succeeded',
7171
timestamp: new Date().getTime(),
7272
platform: process.platform,
@@ -87,7 +87,7 @@ describe(Telemetry.name, () => {
8787
const telemetry: Telemetry = new Telemetry(rushConfig, rushSession);
8888
const logData: ITelemetryData = {
8989
name: 'testData1',
90-
duration: 100,
90+
durationInSeconds: 100,
9191
result: 'Succeeded',
9292
timestamp: new Date().getTime(),
9393
platform: process.platform,
@@ -115,7 +115,7 @@ describe(Telemetry.name, () => {
115115
const telemetry: Telemetry = new Telemetry(rushConfig, rushSession);
116116
const logData: ITelemetryData = {
117117
name: 'testData1',
118-
duration: 100,
118+
durationInSeconds: 100,
119119
result: 'Succeeded'
120120
};
121121

@@ -141,7 +141,7 @@ describe(Telemetry.name, () => {
141141
) as unknown as ITelemetryPrivateMembers;
142142
const logData: ITelemetryData = {
143143
name: 'testData1',
144-
duration: 100,
144+
durationInSeconds: 100,
145145
result: 'Succeeded'
146146
};
147147

@@ -171,7 +171,7 @@ describe(Telemetry.name, () => {
171171
) as unknown as ITelemetryPrivateMembers;
172172
const logData: ITelemetryData = {
173173
name: 'testData1',
174-
duration: 100,
174+
durationInSeconds: 100,
175175
result: 'Succeeded'
176176
};
177177

@@ -182,7 +182,7 @@ describe(Telemetry.name, () => {
182182

183183
const logData2: ITelemetryData = {
184184
name: 'testData2',
185-
duration: 200,
185+
durationInSeconds: 200,
186186
result: 'Failed'
187187
};
188188

‎common/reviews/api/rush-lib.api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ export interface IRushSessionOptions {
352352

353353
// @beta (undocumented)
354354
export interface ITelemetryData {
355-
readonly duration: number;
355+
readonly durationInSeconds: number;
356356
// (undocumented)
357357
readonly extraData?: {
358358
[key: string]: string;

0 commit comments

Comments
 (0)
0