ref(sveltekit): Distinguish spans of server-only and universal load functions (getsentry#7609)

Lms24 · web-flow · commit 5abe629405a3 · 2023-03-24T14:50:34.000+01:00
Adjust the span ops of `load` functions to distinguish between spans of server-only and universal `load` functions (`+page.ts` vs `+page.server.ts`):
diff --git a/packages/sveltekit/src/server/load.ts b/packages/sveltekit/src/server/load.ts
@@ -58,7 +58,7 @@ export function wrapLoadWithSentry<T extends ServerLoad | Load>(origLoad: T): T
       const { traceparentData, dynamicSamplingContext } = getTracePropagationData(event);
 
       const traceLoadContext: TransactionContext = {
-        op: 'function.sveltekit.load',
+        op: `function.sveltekit${isServerOnlyLoad(event) ? '.server' : ''}.load`,
         name: routeId ? routeId : event.url.pathname,
         status: 'ok',
         metadata: {
diff --git a/packages/sveltekit/test/server/load.test.ts b/packages/sveltekit/test/server/load.test.ts
@@ -202,7 +202,7 @@ describe('wrapLoadWithSentry', () => {
         expect(mockTrace).toHaveBeenCalledTimes(1);
         expect(mockTrace).toHaveBeenCalledWith(
           {
-            op: 'function.sveltekit.load',
+            op: 'function.sveltekit.server.load',
             name: '/users/[id]',
             parentSampled: true,
             parentSpanId: '1234567890abcdef',
@@ -233,7 +233,7 @@ describe('wrapLoadWithSentry', () => {
         expect(mockTrace).toHaveBeenCalledTimes(1);
         expect(mockTrace).toHaveBeenCalledWith(
           {
-            op: 'function.sveltekit.load',
+            op: 'function.sveltekit.server.load',
             name: '/users/[id]',
             status: 'ok',
             metadata: {
@@ -252,7 +252,7 @@ describe('wrapLoadWithSentry', () => {
         expect(mockTrace).toHaveBeenCalledTimes(1);
         expect(mockTrace).toHaveBeenCalledWith(
           {
-            op: 'function.sveltekit.load',
+            op: 'function.sveltekit.server.load',
             name: '/users/[id]',
             parentSampled: true,
             parentSpanId: '1234567890abcdef',
