[Form] Update password type trimming to false

GeLoLabs · GeLoLabs · commit 97f6a1b4d941 · 2012-11-16T14:51:56.000+01:00
diff --git a/UPGRADE-2.2.md b/UPGRADE-2.2.md
@@ -31,3 +31,7 @@
    $accepts = AcceptHeader::fromString($request->headers->get('Accept'))->all();
 
    ```
+
+### Form
+
+  * The PasswordType is now not trimmed by default.
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/PasswordType.php b/src/Symfony/Component/Form/Extension/Core/Type/PasswordType.php
@@ -35,6 +35,7 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)
     {
         $resolver->setDefaults(array(
             'always_empty' => true,
+            'trim'         => false,
         ));
     }
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/PasswordTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/PasswordTypeTest.php
@@ -39,4 +39,13 @@ public function testNotEmptyIfBoundAndNotAlwaysEmpty()
 
         $this->assertSame('pAs5w0rd', $view->vars['value']);
     }
+
+    public function testNotTrimmed()
+    {
+        $form = $this->factory->create('password', null);
+        $form->bind(' pAs5w0rd ');
+        $data = $form->getData();
+
+        $this->assertSame(' pAs5w0rd ', $data);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)`
`35`	`35`	`{`
`36`	`36`	`$resolver->setDefaults(array(`
`37`	`37`	`'always_empty' => true,`
	`38`	`+ 'trim' => false,`
`38`	`39`	`));`
`39`	`40`	`}`
`40`	`41`
Original file line number	Diff line number	Diff line change
`@@ -39,4 +39,13 @@ public function testNotEmptyIfBoundAndNotAlwaysEmpty()`
`39`	`39`
`40`	`40`	`$this->assertSame('pAs5w0rd', $view->vars['value']);`
`41`	`41`	`}`
	`42`	`+`
	`43`	`+ public function testNotTrimmed()`
	`44`	`+ {`
	`45`	`+ $form = $this->factory->create('password', null);`
	`46`	`+ $form->bind(' pAs5w0rd ');`
	`47`	`+ $data = $form->getData();`
	`48`	`+`
	`49`	`+ $this->assertSame(' pAs5w0rd ', $data);`
	`50`	`+ }`
`42`	`51`	`}`