small tweak to exception handling

csausdev · csausdev · commit 612d9eeb2332 · 2010-12-11T21:59:50.000+11:00
diff --git a/lib/log4js.js b/lib/log4js.js
@@ -284,7 +284,7 @@ module.exports = function (fileSystem, standardOutput, configPaths) {
         if (exception && exception.message && exception.name) {
             this.exception = exception;
         } else if (exception) {
-            this.exception = new Error(exception);
+            this.exception = new Error(sys.inspect(exception));
         }
     }
 
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
    "name": "log4js",
-   "version": "0.2.1",
+   "version": "0.2.2",
    "description": "Port of Log4js to work with node.",
    "keywords": [
        "logging",
diff --git a/test/logging.js b/test/logging.js
@@ -30,7 +30,7 @@ vows.describe('log4js').addBatch({
 		logger.trace("Trace event 2");
 		logger.warn("Warning event");
                 logger.error("Aargh!", new Error("Pants are on fire!"));
-                logger.error("Simulated CouchDB problem", JSON.stringify({ err: 127, cause: "incendiary underwear" }));
+                logger.error("Simulated CouchDB problem", { err: 127, cause: "incendiary underwear" });
 		return events;
 	    },
 
@@ -52,7 +52,7 @@ vows.describe('log4js').addBatch({
 
             'should convert things that claim to be errors into Error objects': function (events) {
                 assert.instanceOf(events[3].exception, Error);
-                assert.equal(events[3].exception.message, '{"err":127,"cause":"incendiary underwear"}');
+                assert.equal(events[3].exception.message, "{ err: 127, cause: 'incendiary underwear' }");
             },
                 
 	},

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ module.exports = function (fileSystem, standardOutput, configPaths) {`
`284`	`284`	`if (exception && exception.message && exception.name) {`
`285`	`285`	`this.exception = exception;`
`286`	`286`	`} else if (exception) {`
`287`		`- this.exception = new Error(exception);`
	`287`	`+ this.exception = new Error(sys.inspect(exception));`
`288`	`288`	`}`
`289`	`289`	`}`
`290`	`290`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "log4js",`
`3`		`- "version": "0.2.1",`
	`3`	`+ "version": "0.2.2",`
`4`	`4`	`"description": "Port of Log4js to work with node.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"logging",`