Error checking on billing sample code for Slack (GoogleCloudPlatform#4248)

markmirch · leahecole · web-flow · commit 86b81031868d · 2020-07-16T09:31:35.000-07:00
* Error checking on billing sample code for Slack

* Added clarifying comments

* Reviewer cleanup on Slack billing function

* Accidentally included a change from a different issue

Co-authored-by: Leah E. Cole &lt;6719667+leahecole@users.noreply.github.com&gt;
diff --git a/functions/billing/main.py b/functions/billing/main.py
@@ -15,12 +15,14 @@
 # [START functions_billing_limit]
 # [START functions_billing_limit_appengine]
 # [START functions_billing_stop]
+# [START functions_billing_slack]
 import base64
 import json
 import os
 # [END functions_billing_stop]
 # [END functions_billing_limit]
 # [END functions_billing_limit_appengine]
+# [END functions_billing_slack]
 
 # [START functions_billing_limit]
 # [START functions_billing_limit_appengine]
@@ -32,6 +34,7 @@
 
 # [START functions_billing_slack]
 import slack
+from slack.errors import SlackApiError
 # [END functions_billing_slack]
 
 # [START functions_billing_limit]
@@ -42,26 +45,42 @@
 # [END functions_billing_limit]
 
 # [START functions_billing_slack]
-
 # See https://api.slack.com/docs/token-types#bot for more info
 BOT_ACCESS_TOKEN = 'xxxx-111111111111-abcdefghidklmnopq'
-
-CHANNEL_ID = 'C0XXXXXX'
+CHANNEL = 'C0XXXXXX'
 
 slack_client = slack.WebClient(token=BOT_ACCESS_TOKEN)
 
 
 def notify_slack(data, context):
     pubsub_message = data
 
-    notification_attrs = json.dumps(pubsub_message['attributes'])
-    notification_data = base64.b64decode(data['data']).decode('utf-8')
-    budget_notification_text = f'{notification_attrs}, {notification_data}'
+    # For more information, see
+    # https://cloud.google.com/billing/docs/how-to/budgets-programmatic-notifications#notification_format
+    try:
+        notification_attr = json.dumps(pubsub_message['attributes'])
+    except KeyError:
+        notification_attr = "No attributes passed in"
 
-    slack_client.api_call(
-      'chat.postMessage',
-      channel=CHANNEL_ID,
-      text=budget_notification_text)
+    try:
+        notification_data = base64.b64decode(data['data']).decode('utf-8')
+    except KeyError:
+        notification_data = "No data passed in"
+
+    # This is just a quick dump of the budget data (or an empty string)
+    # You can modify and format the message to meet your needs
+    budget_notification_text = f'{notification_attr}, {notification_data}'
+
+    try:
+        slack_client.api_call(
+            'chat.postMessage',
+            json={
+                'channel': CHANNEL,
+                'text'   : budget_notification_text
+            }
+        )
+    except SlackApiError:
+        print('Error posting to Slack')
 # [END functions_billing_slack]
 
 
