E584 Remove experimental from gateway infrastructure (#3272) · kubernetes-sigs/gateway-api@ce6d2c6 · GitHub
[go: up one dir, main page]
Skip to content

Commit ce6d2c6

Browse files
keithmattixrobscott
keithmattix
and
robscott
authored
Remove experimental from gateway infrastructure (#3272)
* Remove experimental from gateway infrastructure Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Codegen Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Change version of protoc-gen-grpc Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Change protoc version Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Update apis/v1/gateway_types.go Co-authored-by: Rob Scott <rob.scott87@gmail.com> * Add a warning about how modifying infrastructure.labels can result in pod churn Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Codegen Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Address PR feedback Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Fix whitespace Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Fixup Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Regen Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Add a git diff Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Regen after rebase Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> --------- Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> Co-authored-by: Rob Scott <rob.scott87@gmail.com>
1 parent cb846ce commit ce6d2c6

File tree

6 files changed

+317
-36
lines changed

6 files changed

+317
-36
lines changed

‎apis/v1/gateway_types.go‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,9 +224,8 @@ type GatewaySpec struct {
224224

225225
// Infrastructure defines infrastructure level attributes about this Gateway instance.
226226
//
227-
// Support: Core
227+
// Support: Extended
228228
//
229-
// <gateway:experimental>
230229
// +optional
231230
Infrastructure *GatewayInfrastructure `json:"infrastructure,omitempty"`
232231

@@ -711,6 +710,9 @@ type GatewayInfrastructure struct {
711710
//
712711
// An implementation may chose to add additional implementation-specific labels as they see fit.
713712
//
713+
// If an implementation maps these labels to Pods, or any other resource that would need to be recreated when labels
714+
// change, it SHOULD clearly warn about this behavior in documentation.
715+
//
714716
// Support: Extended
715717
//
716718
// +optional

‎config/crd/experimental/gateway.networking.k8s.io_gateways.yaml‎

Lines changed: 12 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎config/crd/standard/gateway.networking.k8s.io_gateways.yaml‎

Lines changed: 248 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
0