8000 Update conformance tests with Reasons · kubernetes-sigs/gateway-api@bf4d0ca · GitHub
[go: up one dir, main page]
Skip to content

Commit bf4d0ca

Browse files
author
Nick Young
committed
Update conformance tests with Reasons
Signed-off-by: Nick Young <ynick@vmware.com>
1 parent ac7333a commit bf4d0ca

8 files changed

+8
-4
lines changed

‎conformance/tests/gateway-secret-reference-grant-all-in-namespace.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ var GatewaySecretReferenceGrantAllInNamespace = suite.ConformanceTest{
5050
{
5151
Type: string(v1alpha2.ListenerConditionReady),
5252
Status: metav1.ConditionTrue,
53+
Reason: string(v1alpha2.ListenerReasonReady),
5354
},
5455
},
5556
}}

‎conformance/tests/gateway-secret-reference-grant-specific.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ var GatewaySecretReferenceGrantSpecific = suite.ConformanceTest{
5050
{
5151
Type: string(v1alpha2.ListenerConditionReady),
5252
Status: metav1.ConditionTrue,
53+
Reason: string(v1alpha2.ListenerReasonReady),
5354
},
5455
},
5556
}}

‎conformance/tests/httproute-hostname-intersection.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ var HTTPRouteHostnameIntersection = suite.ConformanceTest{
199199
{
200200
Type: string(v1alpha2.RouteConditionAccepted),
201201
Status: metav1.ConditionFalse,
202+
Reason: string(v1alpha2.RouteReasonNoMatchingListenerHostname),
202203
},
203204
},
204205
}}

‎conformance/tests/httproute-invalid-backendref-nonexistent.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ var HTTPRouteInvalidNonExistentBackendRef = suite.ConformanceTest{
5656

5757
t.Run("HTTP Request to invalid nonexistent backend receive a 500", func(t *testing.T) {
5858
http.MakeRequestAndExpectEventuallyConsistentResponse(t, suite.RoundTripper, gwAddr, http.ExpectedResponse{
59-
Request: http.ExpectedRequest{
59+
Request: http.Request{
6060
Method: "GET",
6161
Path: "/",
6262
},

‎conformance/tests/httproute-invalid-backendref-unknown-kind.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ var HTTPRouteInvalidBackendRefUnknownKind = suite.ConformanceTest{
5757

5858
t.Run("HTTP Request to invalid backend with invalid Kind receives a 500", func(t *testing.T) {
5959
http.MakeRequestAndExpectEventuallyConsistentResponse(t, suite.RoundTripper, gwAddr, http.ExpectedResponse{
60-
Request: http.ExpectedRequest{
60+
Request: http.Request{
6161
Method: "GET",
6262
Path: "/v2",
6363
},

‎conformance/tests/httproute-invalid-cross-namespace-backend-ref.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ var HTTPRouteInvalidCrossNamespaceBackendRef = suite.ConformanceTest{
5959

6060
t.Run("HTTP Request to invalid cross-namespace backend must receive a 500", func(t *testing.T) {
6161
http.MakeRequestAndExpectEventuallyConsistentResponse(t, suite.RoundTripper, gwAddr, http.ExpectedResponse{
62-
Request: http.ExpectedRequest{
62+
Request: http.Request{
6363
Method: "GET",
6464
Path: "/",
6565
},

‎conformance/tests/httproute-invalid-reference-grant.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ var HTTPRouteInvalidReferenceGrant = suite.ConformanceTest{
6969

7070
t.Run("HTTP Request to valid sibling backend should succeed", func(t *testing.T) {
7171
http.MakeRequestAndExpectEventuallyConsistentResponse(t, s.RoundTripper, gwAddr, http.ExpectedResponse{
72-
Request: http.ExpectedRequest{
72+
Request: http.Request{
7373
Method: "GET",
7474
Path: "/",
7575
},

‎conformance/utils/kubernetes/helpers.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ func GatewayAndHTTPRoutesMustBeReady(t *testing.T, c client.Client, controllerNa
165165
{
166166
Type: string(v1alpha2.RouteConditionAccepted),
167167
Status: metav1.ConditionTrue,
168+
Reason: string(v1alpha2.RouteReasonAccepted),
168169
},
169170
},
170171
})

0 commit comments

Comments
 (0)
0