8000 Umbrella issue for OpenAPI v3 related improvements · Issue #60937 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

Umbrella issue for OpenAPI v3 related improvements #60937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 3 tasks
roycaihw opened this issue Mar 8, 2018 · 27 comments
Closed
2 of 3 tasks

Umbrella issue for OpenAPI v3 related improvements #60937

roycaihw opened this issue Mar 8, 2018 · 27 comments
Assignees
@roycaihw
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@roycaihw
Copy link
Member
roycaihw commented Mar 8, 2018 •
edited
Loading

The client libraries in https://github.com/kubernetes-client are generated from the OpenAPI spec that we serve in k/k. Tracking OpenAPI v3 related issues and tooling support around OpenAPI v3 here:

As of today (3/8/2018):

Ref: #51163
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 8, 2018
@roycaihw
Copy link
Member Author
roycaihw commented Mar 8, 2018

/sig api-machinery
/assign

cc @yliaog @mbohlool Please add anything that I missed

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 8, 2018
@roycaihw roycaihw mentioned this issue Mar 8, 2018
Closed
@roycaihw roycaihw mentioned this issue Mar 28, 2018
Closed
@nikhita
Copy link
Member
nikhita commented Apr 17, 2018

/cc @sttts

@sttts
Copy link
Contributor
sttts commented Apr 17, 2018

Can you describe how the given links are connected to v3 support for go-openapi? How do the Java projects relate to a Go library?

@roycaihw
Copy link
Member Author

@sttts kubernetes clients are generated based on openapi spec that we serve in k/k. This issue is tracking:

  1. known issues in kubernetes clients that could be solved if we serve openapi v3 in k/k
  2. required tooling support around client generation if we start to serve openapi v3 in k/k

@sttts
Copy link
Contributor
sttts commented Apr 26, 2018

@roycaihw no, openapi is not used for that.

@roycaihw
Copy link
Member Author

@sttts Are you saying serving openapi v3 in k/k may be not related to issues like #59501? AFAIK kubernetes-client/gen uses the openapi spec to generate non-go clients such as java and python

@sttts
Copy link
Contributor
sttts commented May 7, 2018

Are you saying serving openapi v3 in k/k may be not related to issues like #59501?

I think this was a misunderstanding. The clients in the kubernetes-client use OpenAPI, the Go clients in k/k itself don't.

@roycaihw
Copy link
Member Author
roycaihw commented May 7, 2018

@sttts Updated the first comment

@vosmith
8000 Copy link
vosmith commented Jun 4, 2018

Hi @roycaihw , does this include upgrading to using the enum property in the specs?

For objects like the io.k8s.api.core.v1.Container.ImagePullPolicy the type is string, which could benefit from stricter definitions. I just had a case where the ImagePullPolicy was set to always instead of Always which passed the yaml lint check, but failed to deploy.

@roycaihw
Copy link
Member Author

@vosmith I think enum is supported in openapi v2. Please refer to discussion in #24562. The improvement is tracked in #25716.

Currently in kubernetes we use openapi v3 spec in CRD validation schema where enum is also used.

@vosmith
Copy link
vosmith commented Jun 12, 2018

@roycaihw thank you!

@roycaihw roycaihw mentioned this issue Jul 9, 2018
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2018
@nikhita
Copy link
Member
nikhita commented Sep 13, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 11, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roycaihw
Copy link
Member Author

/reopen
/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot reopened this Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

@roycaihw: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 14, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 12, 2019
@roycaihw
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2019
@yue9944882
Copy link
Member

do you have a timeline for supporting openapi v3 yet?

@yue9944882 yue9944882 mentioned this issue Jun 27, 2019
Open
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2019
@yue9944882
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2019
@lsowen
Copy link
lsowen commented Dec 2, 2019

Looks like swagger-codegen has released v3.0.14, which supports a bunch of languages. @roycaihw do you think this release is sufficient to push this forward?

@roycaihw
Copy link
Member Author
roycaihw commented Dec 2, 2019

@lsowen Thanks. That's great news. @p0lyn0mial is working on a KEP for kubernetes openapi v3 support. Most of our clients have migrated to use openapi-generator.

IMO the generator/tooling is not blocking our clients any more. @yue9944882 has an issue that summarizes v3 spec requirements #79472. Let's close this one and track the issue there.

/close

@k8s-ci-robot
Copy link
Contributor

@roycaihw: Closing this issue.

In response to this:

@lsowen Thanks. That's great news. @p0lyn0mial is working on a KEP for kubernetes openapi v3 support. Most of our clients have migrated to use openapi-generator.

IMO the generator/tooling is not blocking our clients any more. @yue9944882 has an issue that summarizes v3 spec requirements #79472. Let's close this one and track the issue there.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roycaihw roycaihw

Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@sttts @lsowen @vosmith @roycaihw @yue9944882 @nikhita @k8s-ci-robot @fejta-bot
0