Open
Description
There is a strong and growing consensus in sig-node about the need of increasing the test coverage in the kubelet, improving the current testsuite about coverage and reliability. See for example the April 26 sig-node meeting notes and the April 27 sig-node CI subgroup meeting notes.
This work has already begun and there are already some PR posted (see: #108024 (review)). This is a great start. There are more areas in the kubelet, especially in the container manager and resource manager area, that can use better unit test coverage.
Besides the obvious benefits of documenting and preserving the current behaviour, adding tests is meant to lower the barrier for future work and contributions.
Examples of some areas which can benefit of more tests:
- k/k/pkg/kubelet/cm/internal_container_lifecycle.go
- k/k/pkg/kubelet/cm/internal_container_lifecycle_linux.go
- k/k/pkg/kubelet/cm/pod_container_manager_linux.go
- k/k/pkg/kubelet/cm/qos_container_manager_linux.go
- everything coverage-driven (check test code coverage and build from there)
- error paths in general
- e2e tests in general