Fix response schema for delete batch/v1/jobs

JoeryH · JoeryH · commit 09ae333f790a · 2021-06-19T13:50:42.000+02:00
DELETE batch/v1/jobs actually returns a Job resource,
not the generic Status object.

We can use ReturnDeletedObject: true in the storage
configuration to fix this.

Without this fix clients that are generated will be
incorrectly unmarshalling the json and, at least for
the Java client, throw an exception.
diff --git a/pkg/registry/batch/job/storage/storage.go b/pkg/registry/batch/job/storage/storage.go
@@ -68,6 +68,7 @@ func NewREST(optsGetter generic.RESTOptionsGetter) (*REST, *StatusREST, error) {
 		UpdateStrategy:      job.Strategy,
 		DeleteStrategy:      job.Strategy,
 		ResetFieldsStrategy: job.Strategy,
+		ReturnDeletedObject: true,
 
 		TableConvertor: printerstorage.TableConvertor{TableGenerator: printers.NewTableGenerator().With(printersinternal.AddHandlers)},
 	}

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ func NewREST(optsGetter generic.RESTOptionsGetter) (REST, StatusREST, error) {`
`68`	`68`	`UpdateStrategy: job.Strategy,`
`69`	`69`	`DeleteStrategy: job.Strategy,`
`70`	`70`	`ResetFieldsStrategy: job.Strategy,`
	`71`	`+ ReturnDeletedObject: true,`
`71`	`72`
`72`	`73`	`TableConvertor: printerstorage.TableConvertor{TableGenerator: printers.NewTableGenerator().With(printersinternal.AddHandlers)},`
`73`	`74`	`}`