KEP-2170: Add directories for the V2 APIs #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10407466004Details
💛 - Coveralls |
tenzen-y
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Could you add this Dockerfile to the build workflow so that we can ensure the new project is buildable?
https://github.com/kubeflow/training-operator/blob/ff19a10842deba1fdb553a8b89e332731bf4f3ad/.github/workflows/publish-core-images.yaml#L23
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
903b1b3 to
c8689dc
Compare
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
265904a to
b2d5610
Compare
terrytangyuan
approved these changes
Aug 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b2d5610 to
61f92b0
Compare
|
/lgtm |
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
61f92b0 to
e28303f
Compare
|
/lgtm |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2206
I added directory structure for the V2 APIs.
/assign @tenzen-y @kubeflow/wg-training-leads