Fix TrainJob status comparison and update (#2353)

astefanutti · web-flow · commit 01fd1b75a85d · 2024-12-13T17:23:06.000Z
Signed-off-by: Antonin Stefanutti &lt;antonin@stefanutti.fr&gt;
diff --git a/pkg/controller.v2/trainjob_controller.go b/pkg/controller.v2/trainjob_controller.go
@@ -96,7 +96,7 @@ func (r *TrainJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 	if terminalCondErr := setTerminalCondition(ctx, runtime, &trainJob); terminalCondErr != nil {
 		return ctrl.Result{}, errors.Join(err, terminalCondErr)
 	}
-	if !equality.Semantic.DeepEqual(&trainJob, originStatus) {
+	if !equality.Semantic.DeepEqual(&trainJob.Status, originStatus) {
 		return ctrl.Result{}, errors.Join(err, r.client.Status().Update(ctx, &trainJob))
 	}
 	return ctrl.Result{}, err

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ func (r *TrainJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c`
`96`	`96`	`if terminalCondErr : 6209 = setTerminalCondition(ctx, runtime, &trainJob); terminalCondErr != nil {`
`97`	`97`	`return ctrl.Result{}, errors.Join(err, terminalCondErr)`
`98`	`98`	`}`
`99`		`- if !equality.Semantic.DeepEqual(&trainJob, originStatus) {`
	`99`	`+ if !equality.Semantic.DeepEqual(&trainJob.Status, originStatus) {`
`100`	`100`	`return ctrl.Result{}, errors.Join(err, r.client.Status().Update(ctx, &trainJob))`
`101`	`101`	`}`
`102`	`102`	`return ctrl.Result{}, err`