refactor get_attr function to support generic default values

kosiew · kosiew · commit b52166bc1d27 · 2025-04-28T12:36:19.000+08:00
diff --git a/src/dataframe.rs b/src/dataframe.rs
@@ -138,11 +138,14 @@ fn import_python_formatter(py: Python) -> PyResult<Bound<'_, PyAny>> {
     get_formatter.call0()
 }
 // Helper function to extract attributes with fallback to default
-fn get_attr<'a>(py_object: &'a Bound<'a, PyAny>, attr_name: &str, default_value: usize) -> usize {
+fn get_attr<'a, T>(py_object: &'a Bound<'a, PyAny>, attr_name: &str, default_value: T) -> T
+where
+    T: for<'py> pyo3::FromPyObject<'py> + Clone,
+{
     py_object
         .getattr(attr_name)
-        .and_then(|v| v.extract::<usize>())
-        .unwrap_or(default_value)
+        .and_then(|v| v.extract::<T>())
+        .unwrap_or_else(|_| default_value.clone())
 }
 
 /// Helper function to create a FormatterConfig from a Python formatter object
