refactor: update footer comment in DataFrameHtmlFormatter to clarify content

kosiew · kosiew · commit a55bfe0405f8 · 2025-04-08T14:04:47.000+08:00
diff --git a/python/datafusion/html_formatter.py b/python/datafusion/html_formatter.py
@@ -212,7 +212,7 @@ def format_html(
         html.append("</table>")
         html.append("</div>")
 
-        # Add footer with JavaScript only if needed
+        # Add footer (JavaScript and messages)
         if include_styles and self.enable_cell_expansion:
             html.append(self._get_javascript())
 
diff --git a/python/tests/test_dataframe.py b/python/tests/test_dataframe.py
@@ -1540,28 +1540,3 @@ def test_dataframe_repr_html_values(df):
         print(f"HTML output snippet: {html[:500]}...")
 
     assert len(matches) > 0, "Expected pattern of values not found in HTML output"
-
-    html = df._repr_html_()
-    assert html is not None
-
-    # Create a more flexible pattern that handles values being wrapped in spans
-    # This pattern will match the sequence of values 1,4,8,2,5,5,3,6,8 regardless of formatting
-    pattern = re.compile(
-        r"<td[^>]*?>(?:<span[^>]*?>)?1(?:</span>)?</td>.*?"
-        + r"<td[^>]*?>(?:<span[^>]*?>)?4(?:</span>)?</td>.*?"
-        + r"<td[^>]*?>(?:<span[^>]*?>)?8(?:</span>)?</td>.*?"
-        + r"<td[^>]*?>(?:<span[^>]*?>)?2(?:</span>)?</td>.*?"
-        + r"<td[^>]*?>(?:<span[^>]*?>)?5(?:</span>)?</td>.*?"
-        + r"<td[^>]*?>(?:<span[^>]*?>)?5(?:</span>)?</td>.*?"
-        + r"<td[^>]*?>(?:<span[^>]*?>)?3(?:</span>)?</td>.*?"
-        + r"<td[^>]*?>(?:<span[^>]*?>)?6(?:</span>)?</td>.*?"
-        + r"<td[^>]*?>(?:<span[^>]*?>)?8(?:</span>)?</td>",
-        re.DOTALL,
-    )
-
-    # Print debug info if the test fails
-    matches = re.findall(pattern, html)
-    if not matches:
-        print(f"HTML output snippet: {html[:500]}...")
-
-    assert len(matches) > 0, "Expected pattern of values not found in HTML output"
