8000 Add documentation of community / Bazel team ownership (#308) · kku1993/rules_python@4fcc24f · GitHub
[go: up one dir, main page]
Skip to content

Commit 4fcc24f

Browse files
brandjonbrandjon
authored
Add documentation of community / Bazel team ownership (bazel-contrib#308)
This adds a more nuanced CODEOWNERS and explains its purpose in CONTRIBUTING.md. Fixes bazel-contrib#291.
1 parent a0fbf98 commit 4fcc24f

File tree

3 files changed

+44
-2
lines changed

3 files changed

+44
-2
lines changed

‎CODEOWNERS

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,19 @@
1-
* @brandjon @lberki
1+
# NB: Last matching rule takes precedence in CODEOWNERS.
2+
3+
# Fall-through to community maintainers.
4+
* @thundergolfer @andyscott
5+
6+
# Core Python rules belong to the Bazel team.
7+
/python/ @brandjon @lberki
8+
# But not everything under python/ is the core Python rules.
9+
/python/pip.bzl @thundergolfer @andyscott
10+
/python/whl.bzl @thundergolfer @andyscott
11+
/python/requirements.txt @thundergolfer @andyscott
12+
13+
# The proposals dir corresponds to the Bazel proposals process, documented
14+
# here: https://bazel.build/designs/index.html
15+
/proposals/ @brandjon @lberki
16+
17+
# Certain repo metadata files should stay as-is, particularly these.
18+
/LICENSE @brandjon @lberki
19+
/CONTRIBUTING.md @brandjon @lberki

‎CONTRIBUTING.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,3 +62,27 @@ pull request.
6262

6363
<sup>1</sup> See "[Reflections on Trusting Trust](https://en.wikipedia.org/wiki/Backdoor_(computing)#Compiler_backdoors)".
6464

65+
## Core rules
66+
67+
The bulk of this repo is owned and maintained by the Bazel Python community.
68+
However, since the core Python rules (`py_binary` and friends) are still
69+
bundled with Bazel itself, the Bazel team retains ownership of their stubs in
70+
this repository. This will be the case at least until the Python rules are
71+
fully migrated to Starlark code.
72+
73+
Practically, this means that a Bazel team member should approve any PR
74+
concerning the core Python logic. This includes everything under the `python/`
75+
directory except for `pip.bzl`, `whl.bzl`, and `requirements.txt`.
76+
77+
Issues should be triaged as follows:
78+
79+
- Anything concerning the way Bazel implements the core Python rules should be
80+
filed under [bazelbuild/bazel](https://github.com/bazelbuild/bazel), using
81+
the label `team-Rules-python`.
82+
83+
- If the issue specifically concerns the rules_python stubs, it should be filed
84+
here in this repository and use the label `core-rules`.
85+
86+
- Anything else, such as feature requests not related to existing core rules
87+
functionality, should also be filed in this repository but without the
88+
`core-rules` label.

‎README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ changes as they evolve. There are no guarantees for rules underneath the
4343
`experimental/` directory.
4444

4545
This repository is maintained by the Bazel community. Neither Google, nor the
46-
Bazel team provides support for the code. However, this repository is part of
46+
Bazel team, provides support for the code. However, this repository is part of
4747
the test suite used to vet new Bazel releases. See the [How to
4848
contribute](CONTRIBUTING.md) page for information on our development workflow.
4949

0 commit comments

Comments
 (0)
0