[Bugfix] Allow resource id to be zero

lindyhopchris · lindyhopchris · commit 1593f00474de · 2019-10-25T16:58:58.000+01:00
Closes cloudcreativity#445
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 All notable changes to this project will be documented in this file. This project adheres to
 [Semantic Versioning](http://semver.org/) and [this changelog format](http://keepachangelog.com/).
 
+## Unreleased
+
+### Fixed
+- [#445](https://github.com/cloudcreativity/laravel-json-api/issues/445)
+Allow resource identifier to be zero.
+
 ## [1.5.0] - 2019-10-14
 
 ### Added
diff --git a/src/Object/IdentifiableTrait.php b/src/Object/IdentifiableTrait.php
@@ -75,7 +75,7 @@ public function getId()
             throw new RuntimeException('Id member is not a string.');
         }
 
-        if (empty($id)) {
+        if (empty($id) && '0' !== $id) {
             throw new RuntimeException('Id member is an empty string.');
         }
 
diff --git a/tests/lib/Unit/Object/ResourceIdentifierTest.php b/tests/lib/Unit/Object/ResourceIdentifierTest.php
@@ -146,4 +146,10 @@ public function testInvalidId($id)
         $this->expectException(RuntimeException::class);
         ResourceIdentifier::create('posts', $id)->getId();
     }
+
+    public function testZeroId()
+    {
+        $identifier = ResourceIdentifier::create('posts', '0');
+        $this->assertSame('0', $identifier->getId());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public function getId()`
`75`	`75`	`throw new RuntimeException('Id member is not a string.');`
`76`	`76`	`}`
`77`	`77`
`78`		`- if (empty($id)) {`
	`78`	`+ if (empty($id) && '0' !== $id) {`
`79`	`79`	`throw new RuntimeException('Id member is an empty string.');`
`80`	`80`	`}`
`81`	`81`
Original file line number	Diff line number	Diff line change
`@@ -146,4 +146,10 @@ public function testInvalidId($id)`
`146`	`146`	`$this->expectException(RuntimeException::class);`
`147`	`147`	`ResourceIdentifier::create('posts', $id)->getId();`
`148`	`148`	`}`
	`149`	`+`
	`150`	`+ public function testZeroId()`
	`151`	`+ {`
	`152`	`+ $identifier = ResourceIdentifier::create('posts', '0');`
	`153`	`+ $this->assertSame('0', $identifier->getId());`
	`154`	`+ }`
`149`	`155`	`}`