Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 13 commits
- 1 file changed
- 1 contributor
Commits on Aug 15, 2022
-
The original insertBalance function was doing raw value comparisons as opposed to using the tree's comparator. This is clearly unintentional, and would (ultimately) cause the structure to segfault when constructed with the stringData included in the updated test. I've added the fix, scanned the rest of the code for similar issues, and added the appropriate test case which passes successfully with the fix. The jest code coverage increases slightly as well with the changes.
Commits on Sep 12, 2022
Commits on Sep 13, 2022
-
Added a couple of extra elements to the original test tree, and then removed elements in an order such that all previously uncovered branches of code are now covered. Also added an emptyTree structure to test some additional (trivial) base cases.
Commits on Sep 17, 2022
-
-
An iterative analog to the traditional recursive breadth-first-search algorithm for binary trees. This in-place solution uses the pre-existing "traversal" array for both tracking the algorithm as well as storing the result. Also tweaked old code by resetting the traversal array each time the tree is traversed (otherwise you're only allowed to traverse a tree once which doesn't seem correct even with a single traversal function).
Commits on Sep 18, 2022
-
Update BreadthFirstTreeTraversal.js
got rid of unnecessary currentSize added currentNode for clarity
Commits on Sep 25, 2022
-
refactor out traversal member var
.. per earlier discussion w mods also tweaked the tests to achieve 100% coverage
Commits on Nov 10, 2022
-
-
Update GeneratePermutations.test.js
Original test was very limited and also (unnecessarily) strict in that the order of results mattered. I've tweaked the original test so that results can come in any order. Also added additional tests for smaller arrays of strings/booleans. Finally added some sanity testing for larger input arrays.
-
Update GeneratePermutations.test.js
Factorials are now explicit in the last set of tests.
Commits on Nov 12, 2022
-
Update GeneratePermutations.test.js
Leverage package's existing factorial function.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master