Remove context manager (PyMySQL#763)

methane · web-flow · commit e06bbac052bd · 2018-12-19T17:45:43.000+09:00
diff --git a/pymysql/connections.py b/pymysql/connections.py
@@ -490,20 +490,6 @@ def cursor(self, cursor=None):
             return cursor(self)
         return self.cursorclass(self)
 
-    def __enter__(self):
-        """Context manager that returns a Cursor"""
-        warnings.warn(
-            "Context manager API of Connection object is deprecated; Use conn.begin()",
-            DeprecationWarning)
-        return self.cursor()
-
-    def __exit__(self, exc, value, traceback):
-        """On successful exit, commit. On exception, rollback"""
-        if exc:
-            self.rollback()
-        else:
-            self.commit()
-
     # The following methods are INTERNAL USE ONLY (called from Cursor)
     def query(self, sql, unbuffered=False):
         # if DEBUG:
diff --git a/pymysql/tests/test_connection.py b/pymysql/tests/test_connection.py
@@ -450,27 +450,6 @@ def test_read_default_group(self):
         )
         self.assertTrue(conn.open)
 
-    def test_context(self):
-        with self.assertRaises(ValueError):
-            c = self.connect()
-            with pytest.warns(DeprecationWarning):
-                with c as cur:
-                    cur.execute('create table test ( a int ) ENGINE=InnoDB')
-                    c.begin()
-                    cur.execute('insert into test values ((1))')
-                    raise ValueError('pseudo abort')
-        c = self.connect()
-        with pytest.warns(DeprecationWarning):
-            with c as cur:
-                cur.execute('select count(*) from test')
-                self.assertEqual(0, cur.fetchone()[0])
-                cur.execute('insert into test values ((1))')
-        with pytest.warns(DeprecationWarning):
-            with c as cur:
-                cur.execute('select count(*) from test')
-                self.assertEqual(1,cur.fetchone()[0])
-                cur.execute('drop table test')
-
     def test_set_charset(self):
         c = self.connect()
         c.set_charset('utf8mb4')
