8000 indicator: scaffold for crosstracedefaults · keithrob/plotly.js@3df3829 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3df3829

Browse files
committed
indicator: scaffold for crosstracedefaults
1 parent b0c6d25 commit 3df3829

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

src/traces/indicator/defaults.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var cn = require('./constants.js');
1616
// var handleDomainDefaults = require('../../plots/domain').defaults;
1717
// var handleText = require('../bar/defaults').handleText;
1818

19-
module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
19+
function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
2020
function coerce(attr, dflt) {
2121
return Lib.coerce(traceIn, traceOut, attributes, attr, dflt);
2222
}
@@ -66,4 +66,14 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
6666
coerce('delta.valueformat', traceOut.delta.showpercentage ? '2%' : traceOut.valueformat);
6767
coerce('delta.increasing.color');
6868
coerce('delta.decreasing.color');
69+
}
70+
71+
function crossTraceDefaults(/* fullData, fullLayout */) {
72+
// TODO: for bullet, set equal size for label and number if sharing xdomain
73+
// size must be large enough to accomodate the largest label/number
74+
}
75+
76+
module.exports = {
77+
supplyDefaults: supplyDefaults,
78+
crossTraceDefaults: crossTraceDefaults
6979
};

src/traces/indicator/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ module.exports = {
1717

1818
attributes: require('./attributes'),
1919
layoutAttributes: require('./layout_attributes'),
20-
supplyDefaults: require('./defaults'),
20+
supplyDefaults: require('./defaults').supplyDefaults,
21+
crossTraceDefaults: require('./defaults').crossTraceDefaults,
2122
supplyLayoutDefaults: require('./layout_defaults'),
2223

2324
calc: require('./calc').calc,

0 commit comments

Comments
 (0)
0