minor symfony#60393 [FrameworkBundle] Improve readability of disallow_search_engine_index condition (Nowfel2501)

nicolas-grekas · nicolas-grekas · commit a1228e4b8385 · 2025-05-10T10:37:22.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Improve readability of disallow_search_engine_index condition | Q | A | ------------- | --- | Branch? | 6.4, | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT The use of the null coalescing operator (??) combined with the negation operator (!) and PHP's precedence rules makes this condition harder to read and understand—both for humans and IDEs. Even my editor had trouble parsing it correctly. To improve clarity, it's better to make the intention explicit by writing: `if (!($config['disallow_search_engine_index'] ?? false))` This makes the logic easier to follow and avoids any ambiguity. Commits ------- 31be4cf Improve readability of disallow_search_engine_index condition
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -735,7 +735,7 @@ static function (ChildDefinition $definition, AsPeriodicTask|AsCronTask $attribu
             $container->getDefinition('config_cache_factory')->setArguments([]);
         }
 
-        if (!$config['disallow_search_engine_index'] ?? false) {
+        if (!$config['disallow_search_engine_index']) {
             $container->removeDefinition('disallow_search_engine_index_response_listener');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -735,7 +735,7 @@ static function (ChildDefinition $definition, AsPeriodicTask\|AsCronTask $attribu`
`735`	`735`	`$container->getDefinition('config_cache_factory')->setArguments([]);`
`736`	`736`	`}`
`737`	`737`
`738`		`- if (!$config['disallow_search_engine_index'] ?? false) {`
	`738`	`+ if (!$config['disallow_search_engine_index']) {`
`739`	`739`	`$container->removeDefinition('disallow_search_engine_index_response_listener');`
`740`	`740`	`}`
`741`	`741`