10000 minor #49829 [Console][DoctrineBridge] Remove backticks from exceptio… · kbond/symfony@27401c4 · GitHub
[go: up one dir, main page]
Skip to content

Commit 27401c4

Browse files
fabpotfabpot
committed
minor symfony#49829 [Console][DoctrineBridge] Remove backticks from exception messages (alexandre-daubois)
This PR was merged into the 6.3 branch. Discussion ---------- [Console][DoctrineBridge] Remove backticks from exception messages | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | _NA_ | License | MIT | Doc PR | _NA_ Follow-up of symfony#49822 (comment), removes backticks of a few exception messages. Commits ------- 1c4b9e6 [Console][DoctrineBridge][PhpUnitBridge] Remove backticks from exception messages
2 parents c375406 + 1c4b9e6 commit 27401c4

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

‎src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function __construct(ObjectManager $manager, string $class, IdReader $idR
4141
$classMetadata = $manager->getClassMetadata($class);
4242

4343
if ($idReader && !$idReader->isSingleId()) {
44-
throw new \InvalidArgumentException(sprintf('The second argument `$idReader` of "%s" must be null when the query cannot be optimized because of composite id fields.', __METHOD__));
44+
throw new \InvalidArgumentException(sprintf('The second argument "$idReader" of "%s" must be null when the query cannot be optimized because of composite id fields.', __METHOD__));
4545
}
4646

4747
$this->manager = $manager;

‎src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/DoctrineChoiceLoaderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ public function testLoadChoicesForValuesLoadsOnlyChoicesIfValueIsIdReader()
416416
public function testPassingIdReaderWithoutSingleIdEntity()
417417
{
418418
$this->expectException(\InvalidArgumentException::class);
419-
$this->expectExceptionMessage('The second argument `$idReader` of "Symfony\\Bridge\\Doctrine\\Form\\ChoiceList\\DoctrineChoiceLoader::__construct" must be null when the query cannot be optimized because of composite id fields.');
419+
$this->expectExceptionMessage('The second argument "$idReader" of "Symfony\\Bridge\\Doctrine\\Form\\ChoiceList\\DoctrineChoiceLoader::__construct" must be null when the query cannot be optimized because of composite id fields.');
420420

421421
$idReader = $this->createMock(IdReader::class);
422422
$idReader->expects($this->once())

‎src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ public function startTest($test): void
224224
$annotations = Test::parseTestMethodAnnotations(\get_class($test), $test->getName(false));
225225

226226
if (isset($annotations['class']['expectedDeprecation'])) {
227-
$test->getTestResultObject()->addError($test, new AssertionFailedError('`@expectedDeprecation` annotations are not allowed at the class level.'), 0);
227+
$test->getTestResultObject()->addError($test, new AssertionFailedError('"@expectedDeprecation" annotations are not allowed at the class level.'), 0);
228228
}
229229
if (isset($annotations['method']['expectedDeprecation']) || $this->checkNumAssertions = method_exists($test, 'expectDeprecation') && (new \ReflectionMethod($test, 'expectDeprecation'))->getFileName() === (new \ReflectionMethod(ExpectDeprecationTrait::class, 'expectDeprecation'))->getFileName()) {
230230
if (isset($annotations['method']['expectedDeprecation'])) {
@@ -297,7 +297,7 @@ public function endTest($test, $time): void
297297
restore_error_handler();
298298

299299
if (!\in_array('legacy', $groups, true)) {
300-
$test->getTestResultObject()->addError($test, new AssertionFailedError('Only tests with the `@group legacy` annotation can expect a deprecation.'), 0);
300+
$test->getTestResultObject()->addError($test, new AssertionFailedError('Only tests with the "@group legacy" annotation can expect a deprecation.'), 0);
301301
} elseif (!\in_array($test->getStatus(), [BaseTestRunner::STATUS_SKIPPED, BaseTestRunner::STATUS_INCOMPLETE, BaseTestRunner::STATUS_FAILURE, BaseTestRunner::STATUS_ERROR], true)) {
302302
try {
303303
$prefix = "@expectedDeprecation:\n";

‎src/Symfony/Component/Console/Application.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public function setCommandLoader(CommandLoaderInterface $commandLoader)
121121
public function getSignalRegistry(): SignalRegistry
122122
{
123123
if (!$this->signalRegistry) {
124-
throw new RuntimeException('Signals are not supported. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
124+
throw new RuntimeException('Signals are not supported. Make sure that the "pcntl" extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
125125
}
126126

127127
return $this->signalRegistry;
@@ -1003,7 +1003,7 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI
10031003
$commandSignals = $command instanceof SignalableCommandInterface ? $command->getSubscribedSignals() : [];
10041004
if ($commandSignals || $this->dispatcher && $this->signalsToDispatchEvent) {
10051005
if (!$this->signalRegistry) {
1006-
throw new RuntimeException('Unable to subscribe to signal events. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
1006+
throw new RuntimeException('Unable to subscribe to signal events. Make sure that the "pcntl" extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
10071007
}
10081008

10091009
if (Terminal::hasSttyAvailable()) {

0 commit comments

Comments
 (0)
0