Nicla_System: specify if mounted on MKR via begin()

facchinm · facchinm · commit bebe4784dc75 · 2023-01-27T15:18:38.000+01:00
diff --git a/libraries/Nicla_System/src/Nicla_System.cpp b/libraries/Nicla_System/src/Nicla_System.cpp
@@ -23,11 +23,14 @@ void nicla::pingI2CThd() {
   }
 }
 
-bool nicla::begin()
+bool nicla::begin(bool mounted_on_mkr)
 {
-  pinMode(p25, OUTPUT);
-  pinMode(P0_10, OUTPUT);
-  digitalWrite(P0_10, HIGH);
+  if (mounted_on_mkr) {
+    // GPIO3 is on MKR RESET pin, so we must configure it HIGH or it will, well, reset the board :)
+    pinMode(p25, OUTPUT);
+    pinMode(P0_10, OUTPUT);
+    digitalWrite(P0_10, HIGH);
+  }
   Wire1.begin();
   _chg_reg = _pmic.readByte(BQ25120A_ADDRESS, BQ25120A_FAST_CHG);
 #ifndef NO_NEED_FOR_WATCHDOG_THREAD
diff --git a/libraries/Nicla_System/src/Nicla_System.h b/libraries/Nicla_System/src/Nicla_System.h
@@ -23,7 +23,7 @@
 class nicla {
 
 public:
-  static bool begin();
+  static bool begin(bool mounted_on_mkr = false);
   static bool enable3V3LDO();
   static bool enable1V8LDO();
   static bool disableLDO();

Original file line number	Diff line number	Diff line change
`@@ -23,11 +23,14 @@ void nicla::pingI2CThd() {`
`23`	`23`	`}`
`24`	`24`	`}`
`25`	`25`
`26`		`-bool nicla::begin()`
	`26`	`+bool nicla::begin(bool mounted_on_mkr)`
`27`	`27`	`{`
`28`		`- pinMode(p25, OUTPUT);`
`29`		`- pinMode(P0_10, OUTPUT);`
`30`		`- digitalWrite(P0_10, HIGH);`
	`28`	`+ if (mounted_on_mkr) {`
	`29`	`+ // GPIO3 is on MKR RESET pin, so we must configure it HIGH or it will, well, reset the board :)`
	`30`	`+ pinMode(p25, OUTPUT);`
	`31`	`+ pinMode(P0_10, OUTPUT);`
	`32`	`+ digitalWrite(P0_10, HIGH);`
	`33`	`+ }`
`31`	`34`	`Wire1.begin();`
`32`	`35`	`_chg_reg = _pmic.readByte(BQ25120A_ADDRESS, BQ25120A_FAST_CHG);`
`33`	`36`	`#ifndef NO_NEED_FOR_WATCHDOG_THREAD`