Merge pull request prometheus#970 from albertodonato/process-collector-param-type

csmarchbanks · web-flow · commit 377e386ebde9 · 2023-10-24T08:52:34.000-06:00
Mark collector parameter as optional in ProcessCollector and PlatformCollector
diff --git a/prometheus_client/platform_collector.py b/prometheus_client/platform_collector.py
@@ -9,7 +9,7 @@ class PlatformCollector(Collector):
     """Collector for python platform information"""
 
     def __init__(self,
-                 registry: CollectorRegistry = REGISTRY,
+                 registry: Optional[CollectorRegistry] = REGISTRY,
                  platform: Optional[Any] = None,
                  ):
         self._platform = pf if platform is None else platform
diff --git a/prometheus_client/process_collector.py b/prometheus_client/process_collector.py
@@ -1,5 +1,5 @@
 import os
-from typing import Callable, Iterable, Union
+from typing import Callable, Iterable, Optional, Union
 
 from .metrics_core import CounterMetricFamily, GaugeMetricFamily, Metric
 from .registry import Collector, CollectorRegistry, REGISTRY
@@ -20,7 +20,7 @@ def __init__(self,
                  namespace: str = '',
                  pid: Callable[[], Union[int, str]] = lambda: 'self',
                  proc: str = '/proc',
-                 registry: CollectorRegistry = REGISTRY):
+                 registry: Optional[CollectorRegistry] = REGISTRY):
         self._namespace = namespace
         self._pid = pid
         self._proc = proc
