8000 [CHORE] Run Prettier on the other files in the project (#237) · kaicataldo/typescript-eslint@9594717 · GitHub
[go: up one dir, main page]

Skip to content

Commit 9594717

Browse files
j-f1JamesHenry
authored andcommitted
[CHORE] Run Prettier on the other files in the project (typescript-eslint#237)
1 parent a7f542b commit 9594717

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+941
-870
lines changed

packages/eslint-plugin-typescript/.editorconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ indent_size = 4
66
trim_trailing_whitespace = true
77
end_of_line = lf
88
insert_final_newline = true
9+
quote_type = double
910

1011
# yarn / npm uses 2 spaces when it dumps the file after a change
1112
[package.json]

packages/eslint-plugin-typescript/.github/ISSUE_TEMPLATE/bug-report.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,21 @@
11
---
22
name: Bug report
33
about: Report an issue
4-
labels:
5-
4+
labels:
65
---
76

87
<!--
98
If you have a problem with a specific rule, please begin your issue title with [rulename] to make it easier to search for.
10-
I.e. "[no-unused-vars] False positive when fooing the bar"
9+
I.e. "[no-unused-vars] False positive when fooing the bar"
1110
-->
1211

1312
**Repro**
13+
1414
<!--
1515
Include a minimal reproduction case.
1616
Please try to avoid code that isn't directly related to the bug, as it makes it harder to investigate.
1717
-->
18+
1819
```JSON
1920
{
2021
"rules": {
@@ -27,16 +28,12 @@ Please try to avoid code that isn't directly related to the bug, as it makes it
2728
// your repro code case
2829
```
2930

30-
3131
**Expected Result**
3232

33-
3433
**Actual Result**
3534

36-
3735
**Additional Info**
3836

39-
4037
**Versions**
4138

4239
| package | version |
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
---
22
name: Feature request
33
about: Suggest an idea for this project
4-
labels:
5-
4+
labels:
65
---
76

87
I'd like to propose a **new rule / change to an existing rule**.
98

109
**Description**
11-
<!--
10+
11+
<!--
1212
A clear and concise description of what you would like implemented.
1313
Code samples can help immensely in describing painting a picture.
1414
-->
Lines changed: 8 additions & FFA4 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
<!-- Before opening a pull request, either check (`[ ]` → `[x]`) or remove each of these entries) -->
22

33
<!-- If adding a rule -->
4-
- [ ] I’ve filled out the documentation, including all relevant sections and a link to the equivalent TSLint rule if available.
5-
- [ ] I’ve filled out the rule’s category
6-
- [ ] I’ve added documentation for the equivalent TSLint rule (in `extraDescription`)
7-
- [ ] I’ve added the rule documentation link via the helper from `../utils`.
8-
- [ ] I’ve added the rule to the [roadmap](https://github.com/bradzacher/eslint-plugin-typescript/blob/master/ROADMAP.md)
4+
5+
- [ ] I’ve filled out the documentation, including all relevant sections and a link to the equivalent TSLint rule if available.
6+
- [ ] I’ve filled out the rule’s category
7+
- [ ] I’ve added documentation for the equivalent TSLint rule (in `extraDescription`)
8+
- [ ] I’ve added the rule documentation link via the helper from `../utils`.
9+
- [ ] I’ve added the rule to the [roadmap](https://github.com/bradzacher/eslint-plugin-typescript/blob/master/ROADMAP.md)
910

1011
<!-- All PRs that change code -->
11-
- [ ] I’ve added tests for my changes
12+
13+
- [ ] I’ve added tests for my changes

packages/eslint-plugin-typescript/.prettierrc

Lines changed: 0 additions & 11 deletions
This file was deleted.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
jsxBracketSameLine: true
2+
trailingComma: es5
Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
language: node_js
22
sudo: false
33
node_js:
4-
- "6"
5-
- "8"
6-
- "10"
7-
- "11"
4+
- "6"
5+
- "8"
6+
- "10"
7+
- "11"
88
install: yarn
99
script:
10-
- yarn lint
11-
- yarn format-check
12-
- yarn docs:check
13-
- yarn test
10+
- yarn lint
11+
- yarn format-check
12+
- yarn docs:check
13+
- yarn test

packages/eslint-plugin-typescript/.vscode/extensions.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,5 @@
44
"dbaeumer.vscode-eslint",
55
"editorconfig.editorconfig"
66
],
7-
"unwantedRecommendations": [
8-
"hookyqr.beautify",
9-
"dbaeumer.jshint"
10-
]
7+
"unwantedRecommendations": ["hookyqr.beautify", "dbaeumer.jshint"]
118
}

packages/eslint-plugin-typescript/.vscode/settings.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
{
22
// An array of languages where Emmet abbreviations should not be expanded.
3-
"emmet.excludeLanguages": [
4-
"markdown",
5-
"typescript"
6-
],
3+
"emmet.excludeLanguages": ["markdown", "typescript"],
74

85
// An array of language ids which should be validated by ESLint
96
"eslint.validate": [
@@ -31,5 +28,5 @@
3128
"typescript.preferences.importModuleSpecifier": "auto",
3229
"javascript.preferences.quoteStyle": "double",
3330
"typescript.preferences.quoteStyle": "double",
34-
"typescript.updateImportsOnFileMove.enabled": "always",
31+
"typescript.updateImportsOnFileMove.enabled": "always"
3532
}

packages/eslint-plugin-typescript/CONTRIBUTING.md

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,21 @@
22

33
## Commenting and Discussing
44

5-
***Don't be a douche.***
5+
**_Don't be a douche._**
66
Consider the following when commenting:
77

8-
- Everyone is a human (except for the bots).
9-
- Everyone is freely providing their time for this project.
10-
- Everyone wants to build the best tool.
8+
- Everyone is a human (except for the bots).
9+
- Everyone is freely providing their time for this project.
10+
- Everyone wants to build the best tool.
1111

1212
## PR Requirements
1313

1414
For a PR to be merged, you must pass the following checks:
1515

16-
- there must be no lint errors - `yarn lint`
17-
- the code must be formatted - `yarn format`
18-
- your documentation must be up to date - `yarn docs-check`
19-
- all tests must pass - `yarn test`
16+
- there must be no lint errors - `yarn lint`
17+
- the code must be formatted - `yarn format`
18+
- your documentation must be up to date - `yarn docs-check`
19+
- all tests must pass - `yarn test`
2020

2121
There is a commit hook which will help you follow this.
2222
Travis will also automatically run these checks when you submit your PR (and will block us merging until you fix it).
@@ -25,22 +25,22 @@ Travis will also automatically run these checks when you submit your PR (and wil
2525

2626
When adding or changing a rule, you must:
2727

28-
- Ensure your feature / bug has an issue behind it.
29-
- This just makes it easier for people to find information in future, because PRs aren't included in the default issue search.
30-
- Ensure your changes are covered by tests.
31-
- There's no hard and fast rule for how much testing is required, but try to cover as many bases as you can.
32-
- Ensure your changes are documented in the `docs` folder. We're working to standardise how we document rules, but your docs should:
33-
- describe what the rule does, and why you might enable it.
34-
- (if any) outline the settings; how to configure them and what each one does
35-
- have clear examples of valid and invalid code when using the rule. Bonus points for extra cases showing what each setting does.
28+
- Ensure your feature / bug has an issue behind it.
29+
- This just makes it easier for people to find information in future, because PRs aren't included in the default issue search.
30+
- Ensure your changes are covered by tests.
31+
- There's no hard and fast rule for how much testing is required, but try to cover as many bases as you can.
32+
- Ensure your changes are documented in the `docs` folder. We're working to standardise how we document rules, but your docs should:
33+
- describe what the rule does, and why you might enable it.
34+
- (if any) outline the settings; how to configure them and what each one does
35+
- have clear examples of valid and invalid code when using the rule. Bonus points for extra cases showing what each setting does.
3636

3737
When adding a rule, you must also add a link to the rule in the README.md.
3838

3939
## Submitting Issues
4040

41-
- If your issue relates to a rule, start your title with the rule name:
42-
- `[no-unused-vars] False positive when fooing the bar`
43-
- Search for the issue before you ask; we try hard to ensure it's easy to find existing issues.
44-
- Follow the template.
45-
- We've built it to reduce the chance of us going back to ask you for things.
46-
- Don't be lazy and skip parts of it; we'll just ask you for that information anyway, so it'll only delay the process.
41+
- If your issue relates to a rule, start your title with the rule name:
42+
- `[no-unused-vars] False positive when fooing the bar`
43+
- Search for the issue before you ask; we try hard to ensure it's easy to find existing issues.
44+
- Follow the template.
45+
- We've built it to reduce the chance of us going back to ask you for things.
46+
- Don't be lazy and skip parts of it; we'll just ask you for that information anyway, so it'll only delay the process.

0 commit comments

Comments
 (0)
0