rp2/machine_rtc: Check return value from rtc_set_alarm.

kadamski · kadamski · commit aec645a228dd · 2021-06-13T10:33:06.000+02:00
The rtc_set_datetime() from pico-sdk will validate the values in the datetime_t structure and refuse to set the time if they aren't valid. It makes sense to raise an exception if this happens instead of failing silently which might be confusing (as an example, see: micropython#6928 (comment) ).
diff --git a/ports/rp2/machine_rtc.c b/ports/rp2/machine_rtc.c
@@ -86,6 +86,7 @@ STATIC mp_obj_t machine_rtc_datetime(mp_uint_t n_args, const mp_obj_t *args) {
 
         return mp_obj_new_tuple(8, tuple);
     } else {
+        bool ret;
         mp_obj_t *items;
 
         mp_obj_get_array_fixed_n(args[1], 8, &items);
@@ -100,7 +101,10 @@ STATIC mp_obj_t machine_rtc_datetime(mp_uint_t n_args, const mp_obj_t *args) {
             .sec = mp_obj_get_int(items[6]),
         };
 
-        rtc_set_datetime(&t);
+        ret = rtc_set_datetime(&t);
+        if (!ret) {
+            mp_raise_OSError(MP_EINVAL);
+        }
 
     }
     return mp_const_none;
