FIX memory leak in liblinear (scikit-learn#9024)

superbobry · Jeremiah Johnson · commit 967e8c366505 · 2017-12-18T15:17:05.000-05:00
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
diff --git a/sklearn/svm/src/liblinear/liblinear_helper.c b/sklearn/svm/src/liblinear/liblinear_helper.c
@@ -219,6 +219,7 @@ void free_problem(struct problem *problem)
     int i;
     for(i=problem->l-1; i>=0; --i) free(problem->x[i]);
     free(problem->x);
+    free(problem);
 }
 
 void free_parameter(struct parameter *param)
diff --git a/sklearn/svm/src/liblinear/linear.cpp b/sklearn/svm/src/liblinear/linear.cpp
@@ -2910,6 +2910,8 @@ void free_model_content(struct model *model_ptr)
 		free(model_ptr->w);
 	if(model_ptr->label != NULL)
 		free(model_ptr->label);
+	if(model_ptr->n_iter != NULL)
+	    free(model_ptr->n_iter);
 }
 
 void free_and_destroy_model(struct model **model_ptr_ptr)

Original file line number	Diff line number	Diff line change
`@@ -219,6 +219,7 @@ void free_problem(struct problem *problem)`
`219`	`219`	`int i;`
`220`	`220`	`for(i=problem->l-1; i>=0; --i) free(problem->x[i]);`
`221`	`221`	`free(problem->x);`
	`222`	`+ free(problem);`
`222`	`223`	`}`
`223`	`224`
`224`	`225`	`void free_parameter(struct parameter *param)`
Original file line number	Diff line number	Diff line change
`@@ -2910,6 +2910,8 @@ void free_model_content(struct model *model_ptr)`
`2910`	`2910`	`free(model_ptr->w);`
`2911`	`2911`	`if(model_ptr->label != NULL)`
`2912`	`2912`	`free(model_ptr->label);`
	`2913`	`+ if(model_ptr->n_iter != NULL)`
	`2914`	`+ free(model_ptr->n_iter);`
`2913`	`2915`	`}`
`2914`	`2916`
`2915`	`2917`	`void free_and_destroy_model(struct model **model_ptr_ptr)`