In rewriteheap.c (used by VACUUM FULL and CLUSTER), calculate the tuple

hlinnaka · hlinnaka · commit 7c0af833c64c · 2010-11-09T17:48:43.000+02:00
length stored in the line pointer the same way it's calculated in the normal
heap_insert() codepath. As noted by Jeff Davis, the length stored by
raw_heap_insert() included padding but the one stored by the normal codepath
did not. While the mismatch seems to be harmless, inconsistency isn't good,
and the normal codepath has received a lot more testing over the years.

Backpatch to 8.3 where the heap rewrite code was introduced.
diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c
@@ -636,7 +636,7 @@ raw_heap_insert(RewriteState state, HeapTuple tup)
 	}
 
 	/* And now we can insert the tuple into the page */
-	newoff = PageAddItem(page, (Item) heaptup->t_data, len,
+	newoff = PageAddItem(page, (Item) heaptup->t_data, heaptup->t_len,
 						 InvalidOffsetNumber, false, true);
 	if (newoff == InvalidOffsetNumber)
 		elog(ERROR, "failed to add tuple");

Original file line number	Diff line number	Diff line change
`@@ -636,7 +636,7 @@ raw_heap_insert(RewriteState state, HeapTuple tup)`
`636`	`636`	`}`
`637`	`637`
`638`	`638`	`/* And now we can insert the tuple into the page */`
`639`		`- newoff = PageAddItem(page, (Item) heaptup->t_data, len,`
	`639`	`+ newoff = PageAddItem(page, (Item) heaptup->t_data, heaptup->t_len,`
`640`	`640`	`InvalidOffsetNumber, false, true);`
`641`	`641`	`if (newoff == InvalidOffsetNumber)`
`642`	`642`	`elog(ERROR, "failed to add tuple");`