start modernize utils

stonebig · stonebig · commit f88b9044c3cd · 2020-04-08T17:07:21.000+02:00
".run" is more modern and simpler than ".popen" . to use starting Python-3.5+
diff --git a/winpython/__init__.py b/winpython/__init__.py
@@ -28,6 +28,6 @@
 OTHER DEALINGS IN THE SOFTWARE.
 """
 
-__version__ = '2.3.20200406'
+__version__ = '2.3.20200408'
 __license__ = __doc__
 __project_url__ = 'http://winpython.github.io/'
diff --git a/winpython/utils.py b/winpython/utils.py
@@ -253,6 +253,21 @@ def exec_shell_cmd(args, path):
     )
     return decode_fs_string(process.stdout.read())
 
+def exec_run_cmd(args, path=None):
+    """run a single command (*args* is a list of arguments) in optional *path*"""
+    # only applicable to Python-3.5+
+    # python-3.7+ allows to replace "stdout and stderr ", per "capture_output=True"
+    if path:
+        process = subprocess.run(args,
+                                stdout=subprocess.PIPE,
+                                stderr=subprocess.PIPE,
+                                cwd=path)
+    else:
+        process = subprocess.run(args,
+                                stdout=subprocess.PIPE,
+                                stderr=subprocess.PIPE)
+        return  decode_fs_string(process.stdout)
+
 
 def get_r_version(path):
     """Return version of the R installed in *path*"""
diff --git a/winpython/wppm.py b/winpython/wppm.py
@@ -51,9 +51,12 @@ def get_official_description(name):
         dir_path = os.path.dirname(sys.executable)
         this = normalize(name)
         this_len = len(this)
-        pip_ask = 'pip search '+ this
+        pip_ask = ['pip', 'search', this, '--retries', '0']
+        if len(this)<2:  # don't ask stupid things
+            return ''
         try:
-            pip_res = (utils.exec_shell_cmd(pip_ask, dir_path)+'\n').splitlines()
+            #  .run work when .popen fils when no internet
+            pip_res = (utils.exec_run_cmd(pip_ask, dir_path)+'\n').splitlines()
             pip_filter = [l for l in pip_res if this + " (" ==
                           normalize(l[:this_len])+l[this_len:this_len+2]]
             pip_desc = (pip_filter[0][len(this)+1:]).split(" - ", 1)[1] 
