8000 Style cleanup · juanodecc/python-control@1e3109f · GitHub
[go: up one dir, main page]

Skip to content

Commit 1e3109f

Browse files
authored
Style cleanup
1 parent 95ca297 commit 1e3109f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

control/tests/timeresp_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,10 @@ def mimo_ss_step_matlab(self):
301301
'SteadyStateValue': -0.5394},
302302
{'RiseTime': 0.0000, # (*)
303303
'SettlingTime': 3.4000,
304-
'SettlingMin': -0.4350,# -0.1935 in MATLAB. (is wrong)
304+
'SettlingMin': -0.4350, # (*)
305305
'SettlingMax': -0.1485,
306306
'Overshoot': 132.0170,
307-
'Undershoot': 0, # 0. in MATLAB (is correct)
307+
'Undershoot': 0,
308308
'Peak': 0.4350,
309309
'PeakTime': .2,
310310
'SteadyStateValue': -0.1875}]]

control/timeresp.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -926,7 +926,7 @@ def step_info(sysdata, T=None, T_num=None, yfinal=None,
926926
# Undershoot
927927
y_us = (sgnInf*yout).min()
928928
y_us_index = (sgnInf*yout).argmin()
929-
if (sgnInf * yout[y_us_index]) < 0: # must have oposite sign
929+
if (sgnInf * yout[y_us_index]) < 0: # InfValue and undershoot must have opposite sign
930930
undershoot = np.abs(100. * np.abs(y_us) / InfValue)
931931
else:
932932
undershoot = 0

0 commit comments

Comments
 (0)
0