jsullivanlive
diff --git a/‎github3/repos.py
Lines changed: 6 additions & 2 deletions b/‎github3/repos.py
Lines changed: 6 additions & 2 deletions
diff --git a/‎tests/test_repos.py
Lines changed: 63 additions & 9 deletions b/‎tests/test_repos.py
Lines changed: 63 additions & 9 deletions
@@ -1815,7 +1815,11 @@ def __init__(self, compare):
         self._ttl_commits = compare.get('total_commits')
         self._commits = [RepoCommit(com, None) for com in
                 compare.get('commits')]
-        self._files = compare.get('files')
+        self._files = []
+        if compare.get('files'):
+            append = self._files.append
+            for f in compare.get('files'):
+                append(type('Comparison File', (object, ), f))
 
     def __repr__(self):
         return '<Comparison of {0} commits>'.format(self.total_commits)
@@ -1849,7 +1853,7 @@ def diff_url(self):
 
     @property
     def files(self):
-        """List of dictionaries describing the files modified."""
+        """List of objects describing the files modified."""
         return self._files
 
     @property
 
@@ -444,6 +444,20 @@ def test_zipball_url(self):
         expect(self.tag.zipball_url).isinstance(base.str_test)
 
 
+def __test_files__(fd, sha):
+    expect(fd.additions) > 0
+    expect(fd.deletions) >= 0
+    expect(fd.changes) == fd.additions + fd.deletions
+    expect(fd.filename).isinstance(base.str_test)
+    expect(fd.blob_url).isinstance(base.str_test)
+    expect(fd.raw_url).isinstance(base.str_test)
+    expect(fd.sha).isinstance(base.str_test)
+    if sha:
+        expect(fd.sha) == sha
+    expect(fd.status) == 'modified'
+    expect(fd.patch).isinstance(base.str_test)
+
+
 class TestRepoCommit(base.BaseTest):
     def __init__(self, methodName='runTest'):
         super(TestRepoCommit, self).__init__(methodName)
@@ -469,16 +483,56 @@ def test_deletions(self):
     def test_files(self):
         expect(self.commit.files).isinstance(list)
         expect(self.commit.files) > []
+        self.expect_list_of_class(self.commit.files, type)
         for file in self.commit.files:
-            expect(file.additions) > 0
-            expect(file.deletions) > 0
-            expect(file.changes) == file.additions + file.deletions
-            expect(file.filename).isinstance(base.str_test)
-            expect(file.blob_url).isinstance(base.str_test)
-            expect(file.raw_url).isinstance(base.str_test)
-            expect(file.sha) == self.sha
-            expect(file.status) == 'modified'
-            expect(file.patch).isinstance(base.str_test)
+            __test_files__(file, self.sha)
 
     def test_total(self):
         expect(self.commit.total) == 17
+
+
+class TestComparison(base.BaseTest):
+    def __init__(self, methodName='runTest'):
+        super(TestComparison, self).__init__(methodName)
+        repo = self.g.repository(self.sigm, self.todo)
+        self.comp = repo.compare_commits(
+                '04d55444a3ec06ca8d2aa0a5e333cdaf27113254',
+                '731691616b71258c7ad7c141379856b5ebbab310'
+                )
+
+    def test_ahead_by(self):
+        expect(self.comp.ahead_by) > 0
+
+    def test_base_commit(self):
+        expect(self.comp.base_commit).isinstance(RepoCommit)
+
+    def test_behind_by(self):
+        expect(self.comp.behind_by) >= 0
+
+    def test_commits(self):
+        self.expect_list_of_class(self.comp.commits, RepoCommit)
+
+    def test_diff_url(self):
+        expect(self.comp.diff_url).isinstance(base.str_test)
+
+    def test_files(self):
+        expect(self.comp.files).isinstance(list)
+        expect(self.comp.files) > []
+        self.expect_list_of_class(self.comp.files, type)
+        for file in self.comp.files:
+            __test_files__(file, '')
+
+    def test_html_url(self):
+        expect(self.comp.html_url).isinstance(base.str_test)
+
+    def test_patch_url(self):
+        expect(self.comp.patch_url).isinstance(base.str_test)
+
+    def test_permalink_url(self):
+        expect(self.comp.permalink_url).isinstance(base.str_test)
+
+    def test_status(self):
+        expect(self.comp.status) == 'ahead'
+
+    def test_total_commits(self):
+        expect(self.comp.total_commits) == 18