Simple cache for URL building.

sigmavirus24 · sigmavirus24 · commit a246889b4861 · 2012-07-25T10:42:30.000-04:00
If someone uses this module for a long enough period of time, it is likely
that they will end up having to rebuild the same URL more than once. This
should speed up any subsequent calls for it.

If a problem arises from this, I may end up using a caching module to evict
old/unused cache entries, but I somehow doubt this will cause problems at all.
diff --git a/github3/models.py b/github3/models.py
@@ -10,6 +10,8 @@
 from json import dumps
 from requests import session
 
+__url_cache__ = {}
+
 
 class GitHubObject(object):
     """The :class:`GitHubObject <GitHubObject>` object. A basic class to be
@@ -105,7 +107,10 @@ def _build_url(self, *args, **kwargs):
         """Builds a new API url from scratch."""
         parts = [kwargs.get('base_url') or self._github_url]
         parts.extend(args)
-        return '/'.join(parts)
+        key = tuple(parts)
+        if not key in __url_cache__:
+            __url_cache__[key] = '/'.join(parts)
+        return __url_cache__[key]
 
     @property
     def ratelimit_remaining(self):
