All users can now create downloads.

sigmavirus24 · sigmavirus24 · commit 89e6e026b63d · 2012-08-01T23:19:56.000-04:00
Requests version does not matter. Soon though, I will force the requirement to
be whatever version of requests ends up receiving that functionality. I'm not
a fan of the recipe to create my own multipart/form-data encoded string.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -4,5 +4,5 @@ History/Changelog
 0.1: 2012-09-xx
 ---------------
 
-- Support for the complete GitHub API
+- Support for the complete GitHub API (accomplished)
 - Partial coverage (unittests)
diff --git a/github3/repo.py b/github3/repo.py
@@ -8,7 +8,6 @@
 
 from base64 import b64decode
 from json import dumps
-from requests import post
 from .event import Event
 from .issue import Issue, Label, Milestone, issue_params
 from .git import Blob, Commit, Reference, Tag, Tree
@@ -301,10 +300,6 @@ def create_download(self, name, path, description='',
         I do not require you provide the size in bytes because it can be
         determined by the operating system.
 
-        .. warning::
-            This will not work until the release of requests after 0.13.5 or
-            unless I vendorize requests as it is now (1 Aug 2012)
-
         :param str name: (required), name of the file as it will appear
         :param path: (required), path to the file
         :type path: str
@@ -334,9 +329,33 @@ def create_download(self, name, path, description='',
             ('Policy', json.get('policy')),
             ('Signature', json.get('signature')),
             ('Content-Type', json.get('mime_type'))]
-        resp = post(json.get('s3_url'), data=form,
-                files={'file': open(path, 'rb').read()})
-        return resp
+        # While requests doesn't have the ability to accept k/v lists leave
+        # this commented.
+        #file = [('file', open(path, 'rb').read())]
+        #resp = self._post(json.get('s3_url', data=form, files=file,
+        #           auth=tuple())
+
+        # Recipe so we don't need to wait for requests to have this
+        # functionality
+        boundary = '--GitHubBoundary'
+        content_disposition = 'Content-Disposition: form-data; name="{0}"'
+        data = []
+        for (k, v) in form:
+            tmp = [boundary, content_disposition.format(k), '', v]
+            data.extend(tmp)
+        data.append(boundary)
+        data.append(content_disposition.format('file') +
+                '; filename="{0}"'.format(json.get('name')))
+        data.extend(['', open(path, 'rb').read(), boundary + '--', ''])
+        form = '\r\n'.join(data)
+        headers = {'Content-Type': 'multipart/form-data; boundary={0}'.format(
+            boundary[2:]), 'Content-Length': str(len(form))}
+
+        # Need to disable auth so Amazon doesn't think we're trying to
+        # authenticate that way
+        resp = self._post(json.get('s3_url'), data=form, headers=headers,
+                auth=tuple())
+        return resp.status_code == 201
 
     @GitHubCore.requires_auth
     def create_fork(self, organization=None):
